Skip to content

ci: improve cache-hit workflow latency#8682

Draft
thejackshelton wants to merge 2 commits into
QwikDev:build/v2from
thejackshelton:codex-ci-cache-and-e2e-start
Draft

ci: improve cache-hit workflow latency#8682
thejackshelton wants to merge 2 commits into
QwikDev:build/v2from
thejackshelton:codex-ci-cache-and-e2e-start

Conversation

@thejackshelton
Copy link
Copy Markdown
Member

@thejackshelton thejackshelton commented May 28, 2026

Summary

  • restore and save the optimizer cache with the same packages/optimizer/ path
  • make combined-optimizer always provide artifact-optimizer, whether from cache or a fresh native build
  • let build-other-packages restore/upload package artifacts on cache hits
  • start E2E jobs after build artifacts are ready instead of waiting for unit tests
  • skip the npm release job on pull requests
  • skip pkg.pr.new preview publishing while the pull request is a draft
  • remove Playwright slowMo from GitHub CI while keeping it for local runs
  • tighten completed-test cache keys for unit, main E2E, and docs E2E changes

Validation

  • /private/tmp/actionlint-1.7.12/actionlint -color=false .github/workflows/ci.yml
  • /Users/jacksm5pro/dev/open-source/qwik/node_modules/.bin/prettier --no-config --single-quote --trailing-comma es5 --print-width 100 --tab-width 2 --check .github/workflows/ci.yml e2e/qwik-e2e/playwright.config.ts
  • git diff --check
  • NPM_CONFIG_USERCONFIG=/dev/null pnpm --config.platform=linux --config.arch=x64 dedupe --check
  • GitHub Actions run 26608984801: full Qwik CI passed; Release and Release pkg.pr.new both skipped on the draft PR

Security notes

  • cache restores use exact content-derived keys without restore-keys
  • optimizer cache restores require fail-on-cache-miss
  • no new secrets or elevated permissions were added
  • cached optimizer output is re-uploaded as a same-run artifact only after the cache/build prerequisite checks pass

@thejackshelton thejackshelton requested a review from a team as a code owner May 28, 2026 23:26
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 28, 2026

⚠️ No Changeset found

Latest commit: afd025a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@maiieul maiieul moved this to Waiting For Review in Qwik Development May 28, 2026
@thejackshelton thejackshelton marked this pull request as draft May 28, 2026 23:33
@maiieul maiieul moved this from Waiting For Review to In progress in Qwik Development May 28, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 28, 2026

Open in StackBlitz

@qwik.dev/core

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8682

@qwik.dev/router

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8682

eslint-plugin-qwik

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8682

create-qwik

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8682

@qwik.dev/optimizer

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/optimizer@8682

commit: ffca016

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview afd025a

@maiieul
Copy link
Copy Markdown
Member

maiieul commented May 29, 2026

I'd like to keep the pkg.pr.new even for PRs in draft 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

2 participants