Open
Conversation
randy3k
force-pushed
the
release/0.3.17
branch
3 times, most recently
from
ea03527 to
3945d2e
Compare
- Replaced the invalid `terminate()` call with `interrupt()` for `callr::r_bg` process objects in `Task$kill()`, preventing fatal server crashes during task cancellation. - Fixed the graceful teardown in `Session$close()` by calling `close(grace)` directly on the `callr::r_session` object, removing the invalid `get_process()` call.
- Increased `grace` time from 2000ms to 10000ms in `Task$kill()` and `Session$close()` when `R_COVR` is set. This allows processes running on slower CI runners sufficient time to write out test coverage trace data before being forcibly terminated.
Member
Author
|
I removed the session pool e4eed3d Edit: (I nuked session related code for debugging, we might want to re-implment it from stretch) |
randy3k
force-pushed
the
release/0.3.17
branch
2 times, most recently
from
68f2c81 to
0232233
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.