-
Notifications
You must be signed in to change notification settings - Fork 5.3k
新增 国民技术N32 pwm驱动程序 #11071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
新增 国民技术N32 pwm驱动程序 #11071
Conversation
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多余文件请删除
bsp n32 - 快捷方式.lnk
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多余文件
bsp/n32 - 快捷方式.lnk
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多余文件
| * | ||
| * @copyright Copyright (c) 2025 58 | ||
| * | ||
| * 2025-12-2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
日志格式请按照RT-Thread规范编写,另外中文注释建议统一修改为英文
|
commit日志可以规范一下提交 |
|
第1个删除不必要的文件。
第1个是修改日志作者使用自己的邮箱。
第3个是将pr里面的信息修改为英文。
第4个是每次commit的日志都需要用英文写吗?
…---原始邮件---
发件人: "Yuqiang ***@***.***>
发送时间: 2025年12月25日(周四) 上午9:21
收件人: ***@***.***>;
抄送: ***@***.******@***.***>;
主题: Re: [RT-Thread/rt-thread] 添加了国民技术N32G45x和N32L40x的pwm,定时外部时钟1、外部时钟2、pwm脉宽测量驱动程序,修改了串口和SPI的KConfig配置文件 (PR #11071)
@kurisaW requested changes on this pull request.
On 20251218 添加了N32个pwm 和定时器计数,测量脉宽的驱动,增加了V1版串口Kconfig配置,spi驱动Kconfig配置.txt:
多余文件请删除
On bsp n32 - 快捷方式.lnk:
多余文件
On bsp/n32 - 快捷方式.lnk:
多余文件
In bsp/n32/libraries/n32_drivers/drv_pwm.c:
> @@ -0,0 +1,1070 @@ +/** + * @file drv_pwm.c + * @brief + * @author jiache ***@***.***) + * @Version 1.0 + * @Date 2025-12-02 + * + * @copyright Copyright (c) 2025 58 + * + * 2025-12-2
日志格式请按照RT-Thread规范编写,另外中文注释建议统一修改为英文
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
bsp/n32/n32g43xcl-stb/rtconfig.h
Outdated
| #define RT_USING_I2C_BITOPS | ||
| #define RT_USING_ADC | ||
| #define RT_USING_DAC | ||
| #define RT_USING_PWM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rtconfig.h中的这些外设宏定义不必开启,默认保持最小系统配置即可(即仅一个uart作为finsh,其他不是最小系统运行所必须的都默认关闭),修改完成后记得同步mdk或iar工程
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多余文件
| @@ -0,0 +1,981 @@ | |||
| /** | |||
| * @file drv_pwm.c | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| struct rt_device_pwm pwm_device; // pwm obj | ||
| TIM_Module *tim; // timers | ||
| struct n32_pwm_channel ch[4]; // chanel | ||
| uint32_t prescaler; // pre |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注释部分请统一使用 /**/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 38 out of 38 changed files in this pull request and generated 2 comments.
| bool "Enable TIM3 CH3" | ||
| default n | ||
| config BSP_USING_TIM3_PWM_CH3 | ||
| bool "Enable TIM3 CH3" |
Copilot
AI
Jan 15, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
English: Incorrect text - displays "Enable TIM3 CH3" but should be "Enable TIM3 CH4" to match the config name BSP_USING_TIM3_PWM_CH3. This is confusing as CH3 is already used on line 276.
中文:文本错误 - 显示"Enable TIM3 CH3"但应该是"Enable TIM3 CH4"以匹配配置名称 BSP_USING_TIM3_PWM_CH3。这会造成混淆,因为 CH3 已经在第 276 行使用。
| config TIM3_PWM_CH4_PB1 | ||
| bool "PB1 AF2" | ||
| config TIM3_PWM_CH4_PC9 | ||
| bool "PC89 AF2" |
Copilot
AI
Jan 15, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
English: Spelling error - "PC89" should be "PC9" to match other pin naming conventions.
中文:拼写错误 - "PC89" 应该是 "PC9" 以匹配其他引脚命名约定。

拉取/合并请求描述:(PR description)
[
本次PR主要新增了国民技术N32 驱动
并确认并列出已经在什么情况或板卡上进行了测试。
目前已经在2块开发版测试OK,官方所有的开发版的KConfig也做了的修改
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up