Conversation
If the new config option `PVNotifyVanishEnabledPlayersOnSilentMove` is enabled, both `pv.use` and `pv.see` levels are determined upon the player joining the proxy. Logic may be costly, but there is no alternative currently known.
Transforms `ReceiverResolver#getSilentReceivers` to `ReceiverResolver#isSilentReceiver` to prevent the creation of an intermediate List and double loop. Also moves the ternary statement for determining the parseTarget outside the player loop.
`NotifyVanishEnabledPlayersOnSilentMove` will be modified to notify players with either `pv.use` or `pv.see` permissions. This will leave the expensive vanish level determination logic out for PV users who do not use layered permissions. To enable respecting layered permissions, this commit adds a new config option, `NotifyRespectVanishLevels`, to `PluginConfig` and `config.yml`. This and the other permission changes are yet to be implemented as this commit only adds the new permission. Also changed silenced messages to silent messages and update config comments for the new expected functionality.
As a result of using Lombok, `setDisconnecting` now requires a boolean argument and `getPremiumVanishHidden` was renamed to `isPremiumVanishHidden`. These changes are good for consistency and clarity anyway.
This was
linked to
issues
May 14, 2026
Missed in #58.
EarthCow
commented
May 14, 2026
broadcast (59): MessageFormatterTest, ReceiverResolverTest
player (57): LeaveJoinBufferManagerTest, PlayerStateStoreTest, SilenceCheckerTest
storage (42): TextPlayerJoinTrackerTest, (modifies H2PlayerJoinTrackerTest)
util (80): LegacyColorTranslatorTest, PremiumVanishLevelUtilTest
Adds several test files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.