fix: properly resolve symlinked directories in scanner#8
Merged
Railly merged 1 commit intoRailly:mainfrom Apr 2, 2026
Merged
Conversation
…nner - tool-configs.ts: readdirSync was used but never imported, causing a ReferenceError when cliExists scanned the nvm directory - scanner.ts: scanFlatMd and scanDirectoryWithSkillMd assumed all symlinks were directories, crashing with ENOTDIR on symlinked files (e.g. ~/.claude/commands/diff-review.md) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scanDirectoryWithSkillMdandscanFlatMd— instead of treating all symlinks as directories, now resolves the symlink target withstatSyncto verify it actually points to a directoryreaddirSyncimport totool-configs.tsjoin(baseDir, entry.name)intofullPathvariable for clarityContext
The current code does
entry.isDirectory() || entry.isSymbolicLink()which incorrectly treats symlinks to files as directories. This fix usesstatSync(fullPath, { throwIfNoEntry: false })?.isDirectory()to properly check the symlink target.Test plan
🤖 Generated with Claude Code