fixes #408 [Lidarr] Use python3 for pyxdameraulevenshtein calls#410
Open
barrettclark wants to merge 1 commit intoRandomNinjaAtk:mainfrom
Open
fixes #408 [Lidarr] Use python3 for pyxdameraulevenshtein calls#410barrettclark wants to merge 1 commit intoRandomNinjaAtk:mainfrom
barrettclark wants to merge 1 commit intoRandomNinjaAtk:mainfrom
Conversation
…in calls All 4 occurrences of pyxdameraulevenshtein used 'python -c' instead of 'python3 -c'. On Alpine-based containers python may not be symlinked to python3, causing silent failures. When the call returns empty, the integer comparison [ "$diff" -le "$matchDistance" ] throws 'integer expression expected' and the album match loop runs indefinitely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #408
Problem
All 4 calls to
pyxdameraulevenshteininAudio.service.bashusedpython -cinstead ofpython3 -c. On Alpine-based containers (linuxserver/lidarr),pythonmay not be symlinked to Python 3. When the call fails silently (2>/dev/null),$diffis empty and the integer comparison fails:This causes every album title comparison to fail, producing an infinite retry loop and heavy log spam. Previously reported in #180 and closed as user error, but the fix belongs in the script.
Fix
Change all 4 occurrences of
python -ctopython3 -c(lines 1494, 1571, 1643, 1701).pyxdameraulevenshteinis already correctly installed bysetup.bash— this is purely an interpreter name fix.