Conversation
1ba9568 to
80a37c0
Compare
DrPaulSharp
approved these changes
Jan 30, 2026
Collaborator
DrPaulSharp
left a comment
There was a problem hiding this comment.
All looks good and works as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #182
This allows the user change min, value, and max freely in the parameter table, it automatically adjusts the other parameters as needed to keep the min-max relationship for example if the min is set to a value higher than max, this change will automatically set value and max to the new min.
Fixes #186
Fixes #187
This adds a separate close button, saving will no longer close the editor and also makes the editor non-modal so the user can interactive with main window. The editor has been made a singleton to avoid user having multiple editor open at once maybe in the future this can be made into a tab based editor.
Also Fixes #192