Fix custom file crash and contrast not updating custom model#197
Merged
StephenNneji merged 1 commit intoRascalSoftware:mainfrom Feb 4, 2026
Merged
Conversation
DrPaulSharp
approved these changes
Feb 4, 2026
Collaborator
DrPaulSharp
left a comment
There was a problem hiding this comment.
All works as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #196
Fixes #193
Fixes #168
Adding or deleting a custom file should now reflect in the contrast model dropdown
The crash in issue Changing custom file causes crashing and is quite difficult #193 happened on this line
RasCAL-2/rascal2/widgets/delegates.py
Line 63 in 5d846d3
as_posixto unify path style and useddict.getsoNoneis returned if path is not found.I did some refactor so the full path of the custom file does not show up in the table anymore but in a tooltip when the user hovers over the filename cell, hopefully more readable?