Bump bullet from 8.1.2 to 8.1.3#874
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
Bumps [bullet](https://github.com/flyerhzm/bullet) from 8.1.2 to 8.1.3. - [Changelog](https://github.com/flyerhzm/bullet/blob/main/CHANGELOG.md) - [Commits](flyerhzm/bullet@8.1.2...8.1.3) --- updated-dependencies: - dependency-name: bullet dependency-version: 8.1.3 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Test coverage91.64% line coverage reported by SimpleCov. |
There was a problem hiding this comment.
Stale comment
Dependabot assessment: bullet 8.1.2 → 8.1.3
Verdict: Safe to merge.
Lockfile-only patch bump of a
:development/:testgem. CI lint and test both pass (run). Local Docker/Ruby unavailable here; verification via CI.Safety of merging
- No production impact —
bulletis not loaded outside dev/test.- Behaviour change is a false-positive fix — 8.1.3 stops flagging inversed polymorphic
belongs_toreads as unused eager loading / N+1. This reduces noise; it does not change application code or runtime query behaviour.- Low relevance to this codebase — domain models have no polymorphic associations (only Active Storage internals). Bullet is enabled in test with
Bullet.raise = true, and the full suite passed.Concerns unlikely to be caught by tests:
- Real N+1 queries on inversed polymorphic
belongs_toassociations would no longer be reported by Bullet in development — only relevant if such associations are added later.- Subtle changes to Bullet's unused-eager-loading heuristics for that edge case may alter dev-time warnings without affecting CI.
Proposed fixes
None — no failing tests, deprecations, or code changes required.
Sent by Cursor Automation: Editor-* - Tests Dependabot PRs
There was a problem hiding this comment.
Dependabot assessment: bullet 8.1.2 → 8.1.3
Verdict: Safe to merge
Testing
- CI: lint and full RSpec suite passed (run).
- Local: Docker/Ruby unavailable here; relied on CI.
Safety of merging
- Lockfile-only patch bump; no application code changes.
bulletis a dev/test dependency (:development, :test) — not shipped to production.- Test env sets
Bullet.raise = true, so N+1 / unused-eager-loading issues fail the suite. - 8.1.3 fixes false positives for inversed polymorphic
belongs_to(unused-eager-loading noise), building on 8.1.2's optional-nil-polymorphic handling.
Concerns tests may not catch:
- Detection logic for inversed polymorphic associations is relaxed; a real N+1 on such an association could theoretically slip through — low risk here (no app-level polymorphic models; Active Storage is safelisted for
Project.images_attachments). - Development uses
Bullet.raise = false, so log output for polymorphic inverse paths may differ — dev-only, cosmetic.
Proposed fixes
None required.
Sent by Cursor Automation: Editor-* - Tests Dependabot PRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Bumps bullet from 8.1.2 to 8.1.3.
Changelog
Sourced from bullet's changelog.
Commits
bc55c03Bumping version to 8.1.3bf01943Merge pull request #774 from sloane/sloane/shorten-it-block-commentf30f124Fixup ActiveRecord versions899c97fGreen68ad149RedDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)