Skip to content

[8.2] MOD-14826 Use try_lock in debugInfo() to avoid blocking main thread during SVS training#932

Open
github-actions[bot] wants to merge 2 commits into8.2from
backport-931-to-8.2
Open

[8.2] MOD-14826 Use try_lock in debugInfo() to avoid blocking main thread during SVS training#932
github-actions[bot] wants to merge 2 commits into8.2from
backport-931-to-8.2

Conversation

@github-actions
Copy link
Copy Markdown

@github-actions github-actions bot commented Apr 14, 2026

Description

Backport of #931 to 8.2.


Note

Low Risk
Changes only affect debug/status reporting and a flow test assertion; core indexing/search logic is untouched, so functional risk is low aside from potentially different background-indexing flags in diagnostics.

Overview
Prevents TieredSVSIndex::debugInfo() from blocking while SVS background training holds updateJobMutex by switching to try_lock; when the mutex is busy, it reports background indexing as active instead of waiting.

Updates the test_svs_tiered flow test to stop asserting that the flat-buffer size monotonically decreases during background indexing (removing a timing/flakiness-sensitive check).

Reviewed by Cursor Bugbot for commit 2f97044. Bugbot is set up for automated code reviews on this repo. Configure here.

…uring SVS training (#931)

* use try lock

* fix test

(cherry picked from commit d7a5afb)
@GuyAv46 GuyAv46 marked this pull request as draft April 14, 2026 15:25
@GuyAv46 GuyAv46 marked this pull request as ready for review April 14, 2026 15:25
@GuyAv46 GuyAv46 requested a review from meiravgri April 14, 2026 15:25
@meiravgri meiravgri enabled auto-merge April 14, 2026 15:25
@jit-ci
Copy link
Copy Markdown

jit-ci bot commented Apr 14, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.98%. Comparing base (09adad1) to head (2f97044).

Additional details and impacted files
@@            Coverage Diff             @@
##              8.2     #932      +/-   ##
==========================================
- Coverage   97.01%   96.98%   -0.03%     
==========================================
  Files         126      126              
  Lines        7364     7366       +2     
==========================================
  Hits         7144     7144              
- Misses        220      222       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant