[8.2] MOD-14826 Use try_lock in debugInfo() to avoid blocking main thread during SVS training#932
Open
github-actions[bot] wants to merge 2 commits into8.2from
Open
[8.2] MOD-14826 Use try_lock in debugInfo() to avoid blocking main thread during SVS training#932github-actions[bot] wants to merge 2 commits into8.2from
github-actions[bot] wants to merge 2 commits into8.2from
Conversation
2 tasks
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.2 #932 +/- ##
==========================================
- Coverage 97.01% 96.98% -0.03%
==========================================
Files 126 126
Lines 7364 7366 +2
==========================================
Hits 7144 7144
- Misses 220 222 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #931 to
8.2.Note
Low Risk
Changes only affect debug/status reporting and a flow test assertion; core indexing/search logic is untouched, so functional risk is low aside from potentially different background-indexing flags in diagnostics.
Overview
Prevents
TieredSVSIndex::debugInfo()from blocking while SVS background training holdsupdateJobMutexby switching totry_lock; when the mutex is busy, it reports background indexing as active instead of waiting.Updates the
test_svs_tieredflow test to stop asserting that the flat-buffer size monotonically decreases during background indexing (removing a timing/flakiness-sensitive check).Reviewed by Cursor Bugbot for commit 2f97044. Bugbot is set up for automated code reviews on this repo. Configure here.