Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.4 #933 +/- ##
=======================================
Coverage 97.06% 97.06%
=======================================
Files 126 126
Lines 7463 7465 +2
=======================================
+ Hits 7244 7246 +2
Misses 219 219 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #931 to
8.4.Note
Low Risk
Low risk: changes only affect debug/info reporting and a test assertion, with no impact on indexing/query logic beyond how background-indexing status is reported during long training runs.
Overview
Prevents
TieredSVSIndex::debugInfo()from blocking onupdateJobMutexduring long-running SVS training by switching to a non-blockingtry_lockand treating a held mutex as training in progress (reportsindexUpdateScheduled=true).Updates the tiered SVS flow test to stop asserting that the flat-buffer size monotonically decreases during background indexing, and instead asserts the buffer is empty once indexing completes.
Reviewed by Cursor Bugbot for commit 89bcd90. Bugbot is set up for automated code reviews on this repo. Configure here.