Skip to content

[8.4] MOD-14826 Use try_lock in debugInfo() to avoid blocking main thread during SVS training#933

Merged
meiravgri merged 1 commit into8.4from
backport-931-to-8.4
Apr 14, 2026
Merged

[8.4] MOD-14826 Use try_lock in debugInfo() to avoid blocking main thread during SVS training#933
meiravgri merged 1 commit into8.4from
backport-931-to-8.4

Conversation

@github-actions
Copy link
Copy Markdown

@github-actions github-actions bot commented Apr 14, 2026

Description

Backport of #931 to 8.4.


Note

Low Risk
Low risk: changes only affect debug/info reporting and a test assertion, with no impact on indexing/query logic beyond how background-indexing status is reported during long training runs.

Overview
Prevents TieredSVSIndex::debugInfo() from blocking on updateJobMutex during long-running SVS training by switching to a non-blocking try_lock and treating a held mutex as training in progress (reports indexUpdateScheduled=true).

Updates the tiered SVS flow test to stop asserting that the flat-buffer size monotonically decreases during background indexing, and instead asserts the buffer is empty once indexing completes.

Reviewed by Cursor Bugbot for commit 89bcd90. Bugbot is set up for automated code reviews on this repo. Configure here.

…uring SVS training (#931)

* use try lock

* fix test

(cherry picked from commit d7a5afb)
@GuyAv46 GuyAv46 marked this pull request as draft April 14, 2026 15:25
@GuyAv46 GuyAv46 marked this pull request as ready for review April 14, 2026 15:25
@GuyAv46 GuyAv46 requested a review from meiravgri April 14, 2026 15:25
@meiravgri meiravgri merged commit ab15677 into 8.4 Apr 14, 2026
6 checks passed
@meiravgri meiravgri deleted the backport-931-to-8.4 branch April 14, 2026 15:25
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.06%. Comparing base (5e28cb6) to head (89bcd90).
⚠️ Report is 1 commits behind head on 8.4.

Additional details and impacted files
@@           Coverage Diff           @@
##              8.4     #933   +/-   ##
=======================================
  Coverage   97.06%   97.06%           
=======================================
  Files         126      126           
  Lines        7463     7465    +2     
=======================================
+ Hits         7244     7246    +2     
  Misses        219      219           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant