Conversation
…rties are not defined in all branches chore: refactor the no-required-schema-properties rule
🦋 Changeset detectedLatest commit: c0cb033 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Contributor
|
tatomyr
commented
Mar 31, 2026
| }); | ||
|
|
||
| it('should NOT report if one or more of the required properties are defined when used in schema with anyOf keyword', async () => { | ||
| it('should report when required properties are not declared in all anyOf branches', async () => { |
Collaborator
Author
There was a problem hiding this comment.
This is the actual test case added.
tatomyr
commented
Mar 31, 2026
| `); | ||
| }); | ||
|
|
||
| it('should not report required properties are present after resolving $refs when used in schema with allOf keyword', async () => { |
Collaborator
Author
There was a problem hiding this comment.
Removed as duplicated.
tatomyr
commented
Mar 31, 2026
| return {}; | ||
| } | ||
| visitedSchemas.add(schema); | ||
| const hasProperty = ( |
Collaborator
Author
There was a problem hiding this comment.
Refactored similarly to the spec-discriminator-defaultMapping rule.
JLekawa
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why/How?
no-required-schema-properties-undefinedrule to report when a required property is not defined in everyoneOf/anyOfbranch.no-required-schema-propertiesrule code to avoid the 'grandparents' conceptDiscovered internally.
Check yourself
Security