cleanup: normalize named constants in LAPACK *equb routines#1227
Open
nakatamaho wants to merge 1 commit intoReference-LAPACK:masterfrom
Open
cleanup: normalize named constants in LAPACK *equb routines#1227nakatamaho wants to merge 1 commit intoReference-LAPACK:masterfrom
nakatamaho wants to merge 1 commit intoReference-LAPACK:masterfrom
Conversation
…b routines Continue the named-constant cleanup by replacing hard-coded 0.0/0.5/1.0/2.0 literals with ZERO/HALF/ONE/TWO where appropriate, and by normalizing parameter declaration order across the affected *equb routines. No functional change intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR continues the named-constant cleanup in LAPACK by normalizing
constant declarations and replacing hard-coded numeric literals in the
affected
*equbroutines.In particular, it:
ZERO, ONEHALFandTWOwhere needed0.0,0.5,1.0, and2.0literals withthe corresponding named constants in routine bodies
The updates are applied consistently across the affected real/complex
and single/double-precision
*equbvariants.No functional change is intended.
Rationale
These routines already use named constants, but the usage was not fully
consistent across variants. Normalizing the declarations and using the
same named constants in expressions makes the source easier to compare,
review, and maintain across typed implementations.
Affected routines
cgbequb,cgeequb,cheequb,cpoequb,csyequb,dgbequb,dgeequb,dpoequb,dsyequb,sgbequb,sgeequb,spoequb,ssyequb,zgbequb,zgeequb,zheequb,zpoequb,zsyequb.