TESTING/LIN: use ZERO/ONE/CZERO in LQ/QL/QR/RQ error-exit tests#1229
Open
nakatamaho wants to merge 1 commit intoReference-LAPACK:masterfrom
Open
TESTING/LIN: use ZERO/ONE/CZERO in LQ/QL/QR/RQ error-exit tests#1229nakatamaho wants to merge 1 commit intoReference-LAPACK:masterfrom
nakatamaho wants to merge 1 commit intoReference-LAPACK:masterfrom
Conversation
Introduce typed ZERO/ONE parameter constants in the
{s,d,c,z}err{lq,lqt,lqtp,ql,qr,qrt,qrtp,rq} drivers and replace
hard-coded 0/1 literals in test-data initialization.
For the complex variants, add CZERO and use it for complex zero
initialization so the cleanup is type-consistent throughout.
Mechanical cleanup only; no functional change intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces hard-coded
0/1literals in the TESTING/LINerror-exit drivers for the LQ/QL/QR/RQ families with typed named
constants.
For the real variants, it introduces
ZEROandONE.For the complex variants, it also introduces
CZEROand uses it forcomplex zero initialization.
This is a mechanical cleanup only; no functional change is intended.
Scope
The change is limited to the following TESTING/LIN error-exit drivers:
{s,d,c,z}err{lq,lqt,lqtp,ql,qr,qrt,qrtp,rq}What changed
ZERO/ONEparameter constants0/1literals in test-data setupCZEROin the complex variantsCZEROfor consistencyWhy
These files used a mix of literal forms such as
0.,0.0,0.D0,1.,1.E0, and1.D0, plus ad hoc complex zero initializers.Using typed named constants makes the initialization code more uniform
and easier to maintain, without changing behavior.
Testing
Not run.
This is a mechanical source cleanup in the error-exit test drivers only.