Skip to content

TESTING/LIN: use named constants in drvrf tests#1233

Merged
langou merged 1 commit intoReference-LAPACK:masterfrom
nakatamaho:cleanup/testing-lin-drvrf-constants
Apr 13, 2026
Merged

TESTING/LIN: use named constants in drvrf tests#1233
langou merged 1 commit intoReference-LAPACK:masterfrom
nakatamaho:cleanup/testing-lin-drvrf-constants

Conversation

@nakatamaho
Copy link
Copy Markdown
Contributor

@nakatamaho nakatamaho commented Apr 11, 2026

This PR replaces hard-coded floating-point constants in the TESTING/LIN drvrf test drivers with named constants.

Files updated:

TESTING/LIN/cdrvrf3.f
TESTING/LIN/ddrvrf3.f
TESTING/LIN/sdrvrf3.f
TESTING/LIN/zdrvrf3.f
TESTING/LIN/cdrvrfp.f
TESTING/LIN/ddrvrfp.f
TESTING/LIN/sdrvrfp.f
TESTING/LIN/zdrvrfp.f

Summary:

- Replace hard-coded 2.0 divisors in *drvrf3.f with TWO.
- Normalize ZERO, ONE parameter ordering in *drvrfp.f.

Validation:

- Checked that no additional executable floating-point constants such as 0.5, 0.25, or -0.125 remain in these files.
- Ran git diff --check for the updated files.

@nakatamaho
TESTING/LIN: use named constants in drvrf tests
25d74b3 
  Replace hard-coded floating-point constants with existing named
  constants in the drvrf3 and drvrfp test drivers. This keeps the test
  initialization code consistent with surrounding LAPACK test style.
@langou langou merged commit 1c493c4 into Reference-LAPACK:master Apr 13, 2026
12 checks passed
@nakatamaho
Copy link
Copy Markdown
Contributor Author

nakatamaho commented Apr 13, 2026

I appreciate it!

@nakatamaho nakatamaho deleted the cleanup/testing-lin-drvrf-constants branch April 13, 2026 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@langou langou langou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nakatamaho @langou