cleanup: separate real and complex zero/one constants in {c,z}csdts#1234
Open
nakatamaho wants to merge 2 commits intoReference-LAPACK:masterfrom
Open
cleanup: separate real and complex zero/one constants in {c,z}csdts#1234nakatamaho wants to merge 2 commits intoReference-LAPACK:masterfrom
nakatamaho wants to merge 2 commits intoReference-LAPACK:masterfrom
Conversation
Replace REALONE/REALZERO and complex ZERO/ONE with
type-specific named constants in the CSD test routines:
ZERO/ONE for real scalars, and CZERO/CONE for complex values.
Update {C,Z}LASET, {C,Z}GEMM, and {C,Z}HERK call sites to use
the matching constant type, and replace literal imaginary zeros
in CMPLX/DCMPLX calls with the named real ZERO constant.
No functional change intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This cleanup makes the scalar and complex constants explicit in the CSD
test routines.
ccsdts.fandzcsdts.fpreviously used separate real constants(
REALZERO/REALONE) alongside complexZERO/ONE. This changeswitches to real
ZERO/ONEand complexCZERO/CONE, then updatesthe affected call sites to use constants with the intended type.
Changes
ZERO/ONEand complexCZERO/CONE{C,Z}LASET,{C,Z}GEMM, and{C,Z}HERKcall sites to usethe matching real or complex constants
CMPLX/DCMPLXwith thenamed real
ZEROconstantREALZERO/REALONEnaming in these routinesNotes
No functional change intended.
This is a test-code cleanup that makes the constant usage more explicit
and avoids mixing real and complex meanings under the same
ZERO/ONEnames.