Fix complex NRM2 tests for matching infinite results#1264
Open
AymenQ wants to merge 1 commit into
Open
Conversation
The extended complex NRM2 tests can compare an expected +Inf norm with a computed +Inf norm. The relative-error path then evaluates Inf - Inf, producing NaN and reporting a spurious failure. Treat exactly equal results as zero test ratio before computing the relative difference. This matches the existing SNRM2 and DNRM2 test logic. Fixes Reference-LAPACK#1047.
Author
martin-frbg
approved these changes
Jun 9, 2026
Collaborator
|
LGTM though the appropriate reviewer would probably be angsch who authored the NRM2 tests (but may be too busy right now) |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The extended complex NRM2 tests can compare an expected +Inf norm with a computed +Inf norm. The relative-error path then evaluates Inf - Inf, producing NaN and reporting a spurious failure.
Treat exactly equal results as zero test ratio before computing the relative difference. This matches the existing SNRM2 and DNRM2 test logic.
Fixes #1047.
Checklist