Skip to content

docs(platform-fees): simplify configuration guide and remove AI-generated content warning#67

Open
aimensahnoun wants to merge 1 commit into03-02-docs_api-features_rebuild_reconciliation_query_pages_with_correct_v2_endpoints_refactor_query-requests_and_query-payments_docs_to_align_with_actual_api_behavior_and_fix_endpoint_linking_issues_in_openapi_references._-_removed_aifrom
03-02-docs_api-features_rewrite_platform-fees_as_implementation-focused_guide_refactor_api-features_platform-fees.mdx_to_document_platform-fee_configuration_clearly_and_accurately_for_v2_api_consumers._-_remove_ai_placeholder_framing_
Open

docs(platform-fees): simplify configuration guide and remove AI-generated content warning#67
aimensahnoun wants to merge 1 commit into03-02-docs_api-features_rebuild_reconciliation_query_pages_with_correct_v2_endpoints_refactor_query-requests_and_query-payments_docs_to_align_with_actual_api_behavior_and_fix_endpoint_linking_issues_in_openapi_references._-_removed_aifrom
03-02-docs_api-features_rewrite_platform-fees_as_implementation-focused_guide_refactor_api-features_platform-fees.mdx_to_document_platform-fee_configuration_clearly_and_accurately_for_v2_api_consumers._-_remove_ai_placeholder_framing_

Conversation

@aimensahnoun
Copy link
Member

@aimensahnoun aimensahnoun commented Mar 2, 2026

TL;DR

Rewrote the Platform Fees documentation to be more concise and focused on practical implementation.

What changed?

  • Removed AI-generated content warning and disclaimer
  • Simplified the overview section to focus on core functionality
  • Replaced the mermaid diagram and lengthy explanations with direct parameter documentation
  • Restructured content to prioritize required parameters and validation rules upfront
  • Converted JavaScript examples to cURL examples for better API reference alignment
  • Added step-by-step integration guide
  • Removed extensive use case descriptions and theoretical explanations
  • Streamlined the related pages section to focus on relevant documentation

How to test?

  • Verify that the cURL examples work correctly with the API endpoints
  • Test the fee parameter validation rules described in the documentation
  • Confirm that the step-by-step integration guide accurately reflects the implementation process
  • Check that links to related pages and API reference are functional

Why make this change?

The original documentation was verbose and contained AI-generated disclaimers that reduced credibility. The new version provides a cleaner, more actionable reference that developers can quickly scan to understand requirements and implement platform fees without unnecessary complexity.

…uide

Refactor `api-features/platform-fees.mdx` to document platform-fee configuration clearly and accurately for v2 API consumers.
- remove AI placeholder framing and unsupported/ambiguous wording
- focus page scope on platform fee setup (`feePercentage`, `feeAddress`)
- document validation constraints and required parameter pairing
- correct endpoint usage for fee parameters:
  - GET /v2/request/{requestId}/pay
  - POST /v2/payouts
  - POST /v2/payouts/batch
- add cURL examples with `x-api-key` auth style
- add cross-links to Protocol Fees and Fee Breakdowns
- point users to canonical OpenAPI docs for full schemas
Copy link
Member Author

aimensahnoun commented Mar 2, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@aimensahnoun aimensahnoun self-assigned this Mar 2, 2026
@aimensahnoun aimensahnoun changed the title docs(api-features): rewrite platform-fees as implementation-focused guide Refactor api-features/platform-fees.mdx to document platform-fee configuration clearly and accurately for v2 API consumers. - remove AI placeholder framing and unsupported/ambiguo docs(platform-fees): simplify configuration guide and remove AI-generated content warning Mar 2, 2026
@aimensahnoun aimensahnoun marked this pull request as ready for review March 2, 2026 14:33
@greptile-apps
Copy link

greptile-apps bot commented Mar 2, 2026

Greptile Summary

This PR successfully simplifies the platform fees documentation by removing AI-generated content warnings, condensing verbose explanations, and converting JavaScript examples to cURL format for better API reference alignment.

Key improvements:

  • removed AI disclaimer and verbose sections (fee calculation flow, extensive use cases)
  • converted code examples from JavaScript to cURL with proper x-api-key authentication
  • streamlined structure with direct parameter documentation and step-by-step integration guide
  • reduced related pages from 3 to 2 cards

Issues found:

  • Broken links: references to /api-features/protocol-fees don't resolve (page doesn't exist in docs.json navigation)
  • Parameter type inconsistency: ParamField uses query type, but these params are body fields for POST endpoints
  • cURL examples are accurate and correctly show query params for GET and body params for POST

The documentation simplification aligns with the recent pattern seen in other migrated pages (query-requests.mdx, partial-payments.mdx), but the broken protocol-fees references need immediate attention.

Confidence Score: 2/5

  • This PR should not be merged without fixing broken protocol-fees links
  • Score reflects two critical broken links to non-existent protocol-fees page that will cause 404 errors for users. While the documentation improvements are valuable, broken navigation links are user-facing issues that must be resolved before merge
  • api-features/platform-fees.mdx requires fixes for protocol-fees references on lines 15 and 110

Important Files Changed

Filename Overview
api-features/platform-fees.mdx simplified platform fees docs with removed AI warning, but introduces broken protocol-fees links and parameter type inconsistency

Last reviewed commit: ab88d80

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 3 comments

Edit Code Review Agent Settings | Greptile

- **Percentage-Based:** Platform defines `feePercentage` at payment time
- **Smart Contract Level:** API converts percentage to fixed `feeAmount` for smart contract
- **Separate Recipient:** Fees sent to specified `feeAddress`
Use this page for setup and integration patterns. For protocol-level fees charged by Request Network, see [Protocol Fees](/api-features/protocol-fees).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broken link: /api-features/protocol-fees doesn't exist in the repository navigation (verified in docs.json)

Comment on lines +110 to 112
<Card title="Protocol Fees" href="/api-features/protocol-fees">
Understand Request Network protocol-level fees.
</Card>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broken link: "Protocol Fees" card references non-existent page. Remove this card or replace with valid reference

Comment on lines +19 to 25
<ParamField query="feePercentage" type="string">
Fee percentage to apply at payment time (for example `"2.5"` for 2.5%).
</ParamField>

<ParamField body="feeAddress" type="string">
Ethereum address to receive the platform fee
<ParamField query="feeAddress" type="string">
Wallet address that receives the platform fee.
</ParamField>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misleading parameter type: these params use query type, but they're body parameters for POST endpoints listed on lines 42-43. Consider using separate ParamField blocks for each endpoint type, or use generic descriptions without specifying query/body

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs - Make the Beta Docs good enough to link from the website instead of Legacy Docs

1 participant