Package ReCap.CommonUI as a NuGet library (org CI/CD standard)#3
Merged
Conversation
Makes the library publishable to the org GitHub Packages feed and consumable as a PackageReference (instead of a vendored project), part of the org-wide move from submodules/clones to NuGet packages. - build/avalonia.props: Avalonia.Desktop + Avalonia.Diagnostics are now app-host/dev-only (gated to OutputType Exe/WinExe), so they are no longer dependencies of the redistributable library. The demo (WinExe) still gets them. Library deps are now Avalonia, Avalonia.ReactiveUI, Avalonia.Themes.Fluent. - Directory.Build.props: org standard — MinVer (tag-driven versioning), SourceLink, deterministic + embedded PDBs, package metadata (MIT, author Splitwirez). Dropped the static AssemblyVersion (MinVer manages it). - src/ReCap.CommonUI.csproj: IsPackable, PackageId, Description, tags. - demo IsPackable=false; add nuget.config (org feed) + CI workflows (ci, release) that call the org reusable workflows. Build green (lib netstandard2.0 + demo net5.0); pack excludes Desktop/Diagnostics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes ReCap.CommonUI publishable to the org GitHub Packages feed and consumable by the Hub as a
PackageReferenceinstead of a vendored project — part of the org-wide move from submodules/clones to NuGet packages.Changes
build/avalonia.props:Avalonia.Desktop+Avalonia.Diagnosticsare now app-host/dev-only (gated toOutputType=Exe/WinExe), so they're no longer dependencies of the redistributable library. The demo (WinExe) still gets them. Library package deps are now justAvalonia,Avalonia.ReactiveUI,Avalonia.Themes.Fluent.Directory.Build.props: org build standard — MinVer (tag-driven versioning,vX.Y.Z), SourceLink, deterministic + embedded PDBs, package metadata (MIT, author Splitwirez). Dropped the staticAssemblyVersion(MinVer manages it).src/ReCap.CommonUI.csproj:IsPackable,PackageId=ReCap.CommonUI, description, tags.IsPackable=false; addednuget.config(org feed) and CI workflows (ci,release) calling the org reusable workflows.Verification
netstandard2.0+ demonet5.0), 0 errors.dotnet packproducesReCap.CommonUI.<minver>.nupkg; nuspec deps confirmed to exclude Desktop/Diagnostics; README embedded.Notes
Resurrection-Capsule/.githubreusable-workflow repo to exist and be taggedv1(separate setup). Until then the workflows are inert.netstandard2.0).