Skip to content

fix: keep sidebar visible in Firefox#1046

Open
chethanuk wants to merge 1 commit intoRightNow-AI:mainfrom
chethanuk:issue-1036-firefox-sidebar
Open

fix: keep sidebar visible in Firefox#1046
chethanuk wants to merge 1 commit intoRightNow-AI:mainfrom
chethanuk:issue-1036-firefox-sidebar

Conversation

@chethanuk
Copy link
Copy Markdown

Summary

Changes

Testing

  • cargo clippy --workspace --all-targets -- -D warnings passes
  • cargo test --workspace passes
  • Live integration tested (if applicable)

Security

  • No new unsafe code
  • No secrets or API keys in diff
  • User input validated at boundaries

@jaberjaber23
Copy link
Copy Markdown
Member

Confirmed this is the correct fix for #1036 — Firefox's <template x-if> handling of Alpine transitions is flaky, and the x-show + x-cloak + x-transition replacement is the idiomatic Alpine workaround. The added [x-cloak] { display: none !important; } in layout.css is needed to prevent FOUC before Alpine boots.

CI rollup is empty on this branch; please rebase on latest main (we just merged #1041) to get checks running. Assuming they go green, this is ready to land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants