Remove nav2_bringup and add bond_core bondcpp#16
Open
mini-1235 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! As far as I know, Nav2 does not currently release into rolling (it must be built from source), so
nav2_bringupinvinca.yamldoesn't appear to serve a purpose at the moment(?) However, I am interested in building Nav2 with pixi, so I have also addedbond_coreandbondcppin this PR.Question: I also noticed some Nav2-related entries in dependencies.yaml and in the patch directory. Should those be cleaned up as well?