[FEATURE] Create Issues from Messages with Action Buttons#88
Open
henit-chobisa wants to merge 4 commits intoRocketChat:mainfrom
Open
[FEATURE] Create Issues from Messages with Action Buttons#88henit-chobisa wants to merge 4 commits intoRocketChat:mainfrom
henit-chobisa wants to merge 4 commits intoRocketChat:mainfrom
Conversation
Contributor
Author
|
Hey @samad-yar-khan, as we discussed, I have added an action button, for quickly opening issues from messages, |
henit-chobisa
changed the title
samad-yar-khan
suggested changes
Apr 21, 2023
Comment on lines
+30
to
+53
| // TODO We need to download and upload the files to github first, else rocket.chat won't allow accessing images like below | ||
| // const attachmentImageURLs: String[] = [] | ||
| // const attachmentVideoURLs: String[] = [] | ||
| // const settings = this.read.getEnvironmentReader().getServerSettings(); | ||
| // const Site_Url = await settings.getValueById("Site_Url"); | ||
| // if (message.attachments){ | ||
| // message.attachments.map((attachment) => { | ||
| // if (attachment.imageUrl){ | ||
| // attachmentImageURLs.push(`### ${attachment.description?.split("|").pop()}\n`) | ||
| // } | ||
| // if (attachment.videoUrl){ | ||
| // attachmentVideoURLs.push(`### ${attachment.description?.split("|").pop()}\n` + `${Site_Url}/${attachment.videoUrl}`) | ||
| // } | ||
| // }) | ||
| // } | ||
|
|
||
| // if (message.blocks){ | ||
| // message.blocks.map((element) => { | ||
| // if (element.type === BlockType.IMAGE){ | ||
| // element = element as IImageElement | ||
| // attachmentImageURLs.push(`### ${element.altText}\n`) | ||
| // } | ||
| // }) | ||
| // } |
Contributor
There was a problem hiding this comment.
@henit-chobisa These comments need to be fixed, either by code or removed completely.
Contributor
Author
There was a problem hiding this comment.
Sure Samad, I am still on my way to find someway for the images to be processed, what should I do in that case remove these comments and make another PR for that ??
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #87
Issue(s)
Many of the times, customers tend to share their queries directly in the chat, such as reporting a bug or something like a feature request, adding an action button in the list of actions beside a message that pops up a modal which helps in opening an issue can be a very good addition for a user convenience.
Acceptance Criteria fulfillment
SlashCommandContextand also withAction Button Contextmessage.textasdata.templatefor theNewIssueModalShortcuts
<owner/repositor> | <issue>, this will take the repository name and pass it to modal with the issue text as wellProposed changes
Issue Button
Issue without shortcut
Issue with shortcut