fix: correctly render nested quotes media attachments in quotes #1075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for fixing this @Khizarshah01 |
Collaborator
Spiral-Memory
left a comment
Spiral-Memory
left a comment
There was a problem hiding this comment.
LGTM. Can you please attach a video of the current scenario in all variants and show how it looks? Thanks.
Contributor
Author
|
Thanks for the review, @Spiral-Memory Screencast.from.2026-01-17.15-55-22.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Title
Fix nested quoted media rendering and incorrect attachment metadata
Description
This PR fixes an issue where media attachments (images, audio, video) inside nested quoted messages were rendered as generic file attachments.
It also prevents misleading
(0.00 kB)file size metadata from appearing on nested text only quotes.Acceptance Criteria Fulfillment
Fixes #1074
Video/Screenshots
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace
<pr_number>with the actual PR number.