Fix GLTF/GLB importing by using append_from_file instead of buffers#1430
Open
Davidweber01 wants to merge 1 commit into
Open
Fix GLTF/GLB importing by using append_from_file instead of buffers#1430Davidweber01 wants to merge 1 commit into
Davidweber01 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i got this error when trying to load a gltf as model in the new paint project menu:
ERROR: Condition "p_base_path.is_empty()" is true. Returning: ERR_INVALID_PARAMETER
at: _parse_buffers (modules/gltf/gltf_document.cpp:790)
ERROR: Condition "err != OK" is true. Returning: ERR_PARSE_ERROR
at: _parse_gltf_state (modules/gltf/gltf_document.cpp:6930)
ERROR: Condition "err != OK" is true. Returning: err
at: _parse (modules/gltf/gltf_document.cpp:6545)
ERROR: Condition "err != OK" is true. Returning: err
at: append_from_buffer (modules/gltf/gltf_document.cpp:7146)
Failure during parsing GLTF/GLB buffer
cause for the error was probably the empty string in this line:
var err = gltf.append_from_buffer(glb_filebytes, "", gltf_state)
so i changed it to use load_from_file instead, i dont see a reason why the file should first be converted to bytes instead of using the build in function