Skip to content

Fix CLI follow-up routing after completion asks#11844

Merged
cte merged 1 commit intomainfrom
fix/cli-followup-askresponse-routing
Mar 3, 2026
Merged

Fix CLI follow-up routing after completion asks#11844
cte merged 1 commit intomainfrom
fix/cli-followup-askresponse-routing

Conversation

@cte
Copy link
Collaborator

@cte cte commented Mar 3, 2026

Summary

  • route stdin message to askResponse: "messageResponse" when CLI is waiting on an active ask (including completion_result)
  • keep queue behavior for non-ask states
  • add unit coverage for ask-response routing helper
  • add integration case for completion-ask follow-up routing (responded path)
  • relax brittle content assertion in existing follow-up streaming integration test to validate transport invariants

Why

This fixes the regression where a follow-up message sent after attempt_completion could be packaged as tool_result and ignored instead of appearing as a normal user turn.

Validation

  • pnpm exec vitest run src/commands/cli/__tests__/parse-stdin-command.test.ts
  • pnpm exec tsx scripts/integration/cases/followup-completion-ask-response.ts
  • pnpm test:integration (10/10 passed)

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Mar 3, 2026
@cte cte merged commit 06afe42 into main Mar 3, 2026
15 checks passed
@cte cte deleted the fix/cli-followup-askresponse-routing branch March 3, 2026 06:52
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Mar 3, 2026
@github-actions github-actions bot mentioned this pull request Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant