refactor(mypy): un-ignore 5 easy-tier modules#293
Closed
lyskov-ai wants to merge 2 commits into
Closed
Conversation
Fix each module's single pre-existing type error with a pure annotation or setattr change (no behavior change) and remove it from the [[tool.mypy.overrides]] ignore_errors list: - callbacks/train_logging: loss_trackers: dict[str, MeanMetric] - callbacks/metrics_logging: seen_examples: set[str] - common: setattr(wrapper, "_has_run", True) for the @wraps wrapper - hydra/resolvers: attribute_path: str | None (body already guards) - inference_engines/base: base_overrides: dict[str, Any] 13 modules remain on the ignore list. mypy now type-checks the 5 newly-included modules cleanly. Co-authored-by: Sergey Lyskov <sergey.lyskov@jhu.edu>
woodsh17
force-pushed
the
0004-ratchet-mypy-easy-modules
branch
from
64f0ec6 to
a8380e5
Compare
Member
|
The changes covered in this PR were already covered in PR #287 so there are no new changes from this PR, so I am closing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type-checking: fix the type errors in 5 modules and remove them from the
[[tool.mypy.overrides]]ignore_errorslist (18 → 13 remaining), so mypy now type-checks them. Each was a single pure-annotation /setattrfix — no behavior change.Modules:
foundry.callbacks.train_logging,foundry.callbacks.metrics_logging,foundry.common,foundry.hydra.resolvers,foundry.inference_engines.base.Per-module details are in the commit message.