Skip to content

Fibbonachi heap#2

Open
RunFMe wants to merge 5 commits intomasterfrom
FibbonachiHeap
Open

Fibbonachi heap#2
RunFMe wants to merge 5 commits intomasterfrom
FibbonachiHeap

Conversation

@RunFMe
Copy link
Copy Markdown
Owner

@RunFMe RunFMe commented Nov 25, 2018

No description provided.

@RunFMe RunFMe requested a review from rationalex November 25, 2018 17:42
#include <memory>
#include <cassert>
template <class T>
class FibbonachiHeap {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fibonacci

#include <stdexcept>
#include <memory>
#include <cassert>
template <class T>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пустая строка между #include'ами и объявлением класса.

unsigned long size_;
TreeNode* min_root;

void static concat_node_lists(TreeNode* &first_list, TreeNode* second_list) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ааа сокращения в названиях функций. Зачем экономить символы, мы не ядро линукса и не микропроцессоры пишем, где каждый байт на счету.

}
}

unsigned long D() {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Что делает эта функция? Совершенно непонятно из названия.

public:
T value;
bool mark;
TreeNode* left_sib;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сделай shared_ptr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants