minor fixes so Electron plays nicer on Windows#189
Closed
matthargett wants to merge 4 commits intoRunMaestro:mainfrom
Closed
minor fixes so Electron plays nicer on Windows#189matthargett wants to merge 4 commits intoRunMaestro:mainfrom
matthargett wants to merge 4 commits intoRunMaestro:mainfrom
Conversation
… instance aren't launched, taskbar grouping works, etc. eliminate the superfluous toolbar menu space. minor tweaks to align with Electron best practices on Windows from Slack, Discord, VS Code, etc. inlining the hamburger menu into the window chrome requires deeper changes, I can do that next if reclaiming the ~100px height is useful (or we just like the modern look).
…et to the left of the MAESTRO text
…x-windows-electron-issues
Collaborator
|
@matthargett sorry it's taken forever to get to this PR. I'm getting Maestro for Windows setup this weekend and can get hands on testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
give the main window a name that Windows understands
eliminate the superfluous toolbar menu space. minor tweaks to align with Electron best practices on Windows from Slack, Discord, VS Code, etc.
maybe next: inlining the hamburger menu into the window chrome requires deeper changes, I can do that next if reclaiming the ~100px height is useful (or we just like the modern look).