Skip to content

Synchrnous PI fixes from feedback#1228

Open
sethbern wants to merge 1 commit into
RunestoneInteractive:mainfrom
sethbern:sync-pi-feedback-v2
Open

Synchrnous PI fixes from feedback#1228
sethbern wants to merge 1 commit into
RunestoneInteractive:mainfrom
sethbern:sync-pi-feedback-v2

Conversation

@sethbern
Copy link
Copy Markdown
Contributor

@sethbern sethbern commented Jun 4, 2026

Fixed several sync PI issues from testing feedback:

  • Show real student names in the verbal group select dropdown instead of anonymous names
  • Fixed premature "discuss" message after vote 1 stops
  • Added line numbers to code blocks displayed in PI questions (does not touch the actual questions, just adds them visually during a PI session based on instructor feedback that it makes discussion easier)
  • Improved group select placeholder text

Also, some PI pages still seem to route to web2py instead of FastAPI. I think it's because nginx serves /staticAssets/ from the web2py static directory, but if it's something else on my end let me know and I can fix it.

@sethbern sethbern requested a review from bnmnetp as a code owner June 4, 2026 15:52
@bnmnetp
Copy link
Copy Markdown
Member

bnmnetp commented Jun 5, 2026

When we build the nginx container we copy only the components/rsptx/templates/staticAssets folder into the nginx container. It does not have access to the web2py files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants