Merged
Conversation
matteomiceli
force-pushed
the
synonyms
branch
2 times, most recently
from
bac1c9c to
817b3be
Compare
matteomiceli
force-pushed
the
synonyms
branch
from
817b3be to
0eb589b
Compare
- adds synonym support to dictionaries - adds variant (synonym) support for dictfile formatting
Do not write to dict file every loop -- write to byte array instead. Significantly reduces io operations and gives us more control over the generated file.
Before adding synonym support, I want some assurance that dictionary conversion isn't regressing.
matteomiceli
changed the title
matteomiceli
force-pushed
the
synonyms
branch
10 times, most recently
from
6b2df8e to
000e0f6
Compare
tests the epub shape required for kindlegen ingestion
No longer using converting between sets and arrays and only iterating through the lexicon once.
Introduces better newline handling in definition parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces variant word matches across kobo, kindle, and stardict formats. Parses redirects as synonyms.