Update toolchain 2026-03-06 by LegNeato · Pull Request #545 · Rust-GPU/rust-gpu

LegNeato · 2026-03-07T00:03:26Z

Requires #542

- Rewrite extern C fn sigs to Rust ABI to satisfy new rustc fn_abi sanity checks. - Handle direct calls represented as ptr<void> by recovering function signature from callee type/fn_abi. - Keep generated SPIR-V target JSON aligned with backend target options and rustc 1.93 schema expectations.

Refresh expected stderr for debug_printf trait-path wording and unwrap_or line mapping changes.

Normalize target-spec JSON before comparing backend-expected vs provided JSON by dropping the is-like-gpu key, which rustc rejects in external target JSON for non-nvptx/amdgcn targets.

LegNeato · 2026-03-07T00:06:20Z

crates/rustc_codegen_spirv/src/builder/intrinsics.rs

+        _args: &[OperandRef<'tcx, Self::Value>],
+        _is_cleanup: bool,
+    ) -> Self::Value {
+        bug!("LLVM intrinsic call not supported in SPIR-V backend: {instance:?}")


I think we want to use this rather than our own home-grown replacements, but didn't want to do it in this PR.

nazar-pc · 2026-03-07T14:27:06Z

cargo-gpu will need to be updated again to match this, custom target specs since recently require an unstable CLI option:

error: `.json` target specs require -Zjson-target-spec

nazar-pc · 2026-03-08T07:29:47Z

Tried to update with a patched cargo-gpu locally and it worked, but generated these warnings that were not present before:

Details

warning: failed to find and remove `format_args!` construction for this `panic!`
    --> /home/nazar-pc/.rustup/toolchains/nightly-2026-03-06-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ptr/mod.rs:2086:9
     |
2086 | /         ub_checks::assert_unsafe_precondition!(
2087 | |             check_language_ub,
2088 | |             "ptr::read_volatile requires that the pointer argument is aligned",
...    |
2092 | |             ) => ub_checks::maybe_is_aligned(addr, align)
2093 | |         );
     | |_________^
     |
     = note: compilation may later fail due to leftover `format_args!` internals
     = note: [RUST-GPU BUG] bailed from panic entry-point call args

warning: failed to find and remove `format_args!` construction for this `panic!`
   --> /home/nazar-pc/.rustup/toolchains/nightly-2026-03-06-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ptr/mod.rs:531:5
    |
531 | /     ub_checks::assert_unsafe_precondition!(
532 | |         check_language_ub,
533 | |         "ptr::copy_nonoverlapping requires that both pointer arguments are aligned and non-null \
534 | |         and the specified memory ranges do not overlap",
...   |
547 | |     );
    | |_____^
    |
    = note: compilation may later fail due to leftover `format_args!` internals
    = note: [RUST-GPU BUG] bailed from panic entry-point call args

warning: failed to find and remove `format_args!` construction for this `panic!`
   --> /home/nazar-pc/.rustup/toolchains/nightly-2026-03-06-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/slice/index.rs:240:9
    |
240 | /         assert_unsafe_precondition!(
241 | |             check_language_ub, // okay because of the `assume` below
242 | |             "slice::get_unchecked requires that the index is within the slice",
243 | |             (this: usize = self, len: usize = slice.len()) => this < len
244 | |         );
    | |_________^
    |
    = note: compilation may later fail due to leftover `format_args!` internals
    = note: [RUST-GPU BUG] bailed from fmt::Arguments::new call sequence ([Call(59851, 1387, [3516, 3517])])

warning: failed to find and remove `format_args!` construction for this `panic!`
   --> /home/nazar-pc/.rustup/toolchains/nightly-2026-03-06-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/slice/index.rs:240:9
    |
240 | /         assert_unsafe_precondition!(
241 | |             check_language_ub, // okay because of the `assume` below
242 | |             "slice::get_unchecked requires that the index is within the slice",
243 | |             (this: usize = self, len: usize = slice.len()) => this < len
244 | |         );
    | |_________^
    |
    = note: compilation may later fail due to leftover `format_args!` internals
    = note: [RUST-GPU BUG] bailed from fmt::Arguments::new call sequence ([Call(59882, 1390, [3522, 3523])])

warning: failed to find and remove `format_args!` construction for this `panic!`
   --> /home/nazar-pc/.rustup/toolchains/nightly-2026-03-06-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/slice/index.rs:260:9
    |
260 | /         assert_unsafe_precondition!(
261 | |             check_library_ub,
262 | |             "slice::get_unchecked_mut requires that the index is within the slice",
263 | |             (this: usize = self, len: usize = slice.len()) => this < len
264 | |         );
    | |_________^
    |
    = note: compilation may later fail due to leftover `format_args!` internals
    = note: [RUST-GPU BUG] bailed from fmt::Arguments::new call sequence ([Call(59911, 1381, [3527, 3528])])

warning: failed to find and remove `format_args!` construction for this `panic!`
   --> /home/nazar-pc/.rustup/toolchains/nightly-2026-03-06-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/slice/index.rs:240:9
    |
240 | /         assert_unsafe_precondition!(
241 | |             check_language_ub, // okay because of the `assume` below
242 | |             "slice::get_unchecked requires that the index is within the slice",
243 | |             (this: usize = self, len: usize = slice.len()) => this < len
244 | |         );
    | |_________^
    |
    = note: compilation may later fail due to leftover `format_args!` internals
    = note: [RUST-GPU BUG] bailed from fmt::Arguments::new call sequence ([Call(59936, 1393, [3533, 3534])])

warning: failed to find and remove `format_args!` construction for this `panic!`
   --> /home/nazar-pc/.rustup/toolchains/nightly-2026-03-06-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/slice/index.rs:240:9
    |
240 | /         assert_unsafe_precondition!(
241 | |             check_language_ub, // okay because of the `assume` below
242 | |             "slice::get_unchecked requires that the index is within the slice",
243 | |             (this: usize = self, len: usize = slice.len()) => this < len
244 | |         );
    | |_________^
    |
    = note: compilation may later fail due to leftover `format_args!` internals
    = note: [RUST-GPU BUG] bailed from fmt::Arguments::new call sequence ([Call(59967, 1396, [3539, 3540])])

warning: failed to find and remove `format_args!` construction for this `panic!`
   --> /home/nazar-pc/.rustup/toolchains/nightly-2026-03-06-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/slice/index.rs:240:9
    |
240 | /         assert_unsafe_precondition!(
241 | |             check_language_ub, // okay because of the `assume` below
242 | |             "slice::get_unchecked requires that the index is within the slice",
243 | |             (this: usize = self, len: usize = slice.len()) => this < len
244 | |         );
    | |_________^
    |
    = note: compilation may later fail due to leftover `format_args!` internals
    = note: [RUST-GPU BUG] bailed from fmt::Arguments::new call sequence ([Call(59998, 1399, [3545, 3546])])

warning: failed to find and remove `format_args!` construction for this `panic!`
   --> /home/nazar-pc/.rustup/toolchains/nightly-2026-03-06-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/slice/index.rs:260:9
    |
260 | /         assert_unsafe_precondition!(
261 | |             check_library_ub,
262 | |             "slice::get_unchecked_mut requires that the index is within the slice",
263 | |             (this: usize = self, len: usize = slice.len()) => this < len
264 | |         );
    | |_________^
    |
    = note: compilation may later fail due to leftover `format_args!` internals
    = note: [RUST-GPU BUG] bailed from fmt::Arguments::new call sequence ([Call(60027, 1384, [3550, 3551])])

warning: failed to find and remove `format_args!` construction for this `panic!`
   --> /home/nazar-pc/.rustup/toolchains/nightly-2026-03-06-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/slice/index.rs:240:9
    |
240 | /         assert_unsafe_precondition!(
241 | |             check_language_ub, // okay because of the `assume` below
242 | |             "slice::get_unchecked requires that the index is within the slice",
243 | |             (this: usize = self, len: usize = slice.len()) => this < len
244 | |         );
    | |_________^
    |
    = note: compilation may later fail due to leftover `format_args!` internals
    = note: [RUST-GPU BUG] bailed from fmt::Arguments::new call sequence ([Call(60052, 1402, [3556, 3557])])

warning: failed to find and remove `format_args!` construction for this `panic!`
   --> /home/nazar-pc/.rustup/toolchains/nightly-2026-03-06-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/slice/index.rs:326:9
    |
326 | /         assert_unsafe_precondition!(
327 | |             check_library_ub,
328 | |             "slice::get_unchecked_mut requires that the index is within the slice",
329 | |             (end: usize = self.end(), len: usize = slice.len()) => end <= len
330 | |         );
    | |_________^
    |
    = note: compilation may later fail due to leftover `format_args!` internals
    = note: [RUST-GPU BUG] bailed from fmt::Arguments::new call sequence ([Call(60985, 1071, [60970]), Call(60988, 1378, [3948, 3949])])

LegNeato · 2026-03-08T08:11:48Z

Cool, I'll take a look. There were some changes in this area.

fee1-dead · 2026-03-09T23:46:30Z

crates/rustc_codegen_spirv/src/builder/builder_methods.rs

+    fn get_funclet_cleanuppad(&self, _funclet: &Self::Funclet) -> Self::Value {
+        bug!("Funclets are not supported")
+    }


There is inconsistent style between this function and the function above. They should either both use self.fatal or use bug!. And they should either both ignore arguments with leading underscore or put them into let _ =. My vote is on using bug! and leading underscore.

fee1-dead · 2026-03-09T23:55:37Z

crates/rustc_codegen_spirv/src/builder/format_args_decompiler.rs

I wonder whether this is still needed? After #148789, we can simply detect Arguments::from_str if the argument is a const str.

fee1-dead · 2026-03-09T23:55:56Z

crates/rustc_codegen_spirv/src/builder/intrinsics.rs


        let value = match name {
-            sym::likely | sym::unlikely => {
+            _ if name == sym::unlikely || name.as_str() == "likely" => {


Is there any reason for this change?

Firestar99 and others added 18 commits March 6, 2026 13:39

update toolchain to 2025-11-13, fails

a731c2d

adjust target declaration, conflicts with target declaration refactor

8aed8db

see #491

make build.rs handle macOS non-utf8 metadata files

b4c3e49

Update compiletest baselines for new nightly diagnostics

5819774

Refresh expected stderr for debug_printf trait-path wording and unwrap_or line mapping changes.

Ignore is-like-gpu in target-spec JSON comparison

3bbb1fd

Normalize target-spec JSON before comparing backend-expected vs provided JSON by dropping the is-like-gpu key, which rustc rejects in external target JSON for non-nvptx/amdgcn targets.

Fix clippy single_match_else in call callee type handling

6e009cc

Update pinned toolchain to nightly-2026-03-06

10389c9

Port backend trait surface to rustc 1.96 APIs

7db643c

Port backend internals and ABI plumbing to latest nightly

24201f6

Handle newer panic format_args lowering patterns

131d5ac

Handle nightly panic format_args lowering and unsized const reification

1693d02

Fix new nightly clippy suggestions in type trie and linker

b591923

Port linker test harness to current rustc session APIs

c14bd5b

Resolve new collapsible-match clippy lints in example runners

d14c956

Guard runtime-array const reification against truncation and ZST tails

14ba846

Replace fmt::Arguments sentinel metadata with typed constructor tags

bf414e8

Gate bounds/precondition panic-entry detection to non-local core symbols

cb223c7

LegNeato commented Mar 7, 2026

View reviewed changes

LegNeato added 2 commits March 6, 2026 16:15

Fix panic-entry matching and disable-pqp unused-features lint

e1591d0

Bless compiletest stderr for updated nightly diagnostics

6434ab8

LegNeato force-pushed the pr-542-latest-nightly-refresh branch from 14cdf92 to 6434ab8 Compare March 7, 2026 00:22

LegNeato added 8 commits March 6, 2026 16:25

Rustfmt codegen_cx panic-entry matcher formatting

cab2c49

spirv-builder: pass -Zjson-target-spec for JSON targets

929fe0c

compiletests: bless sampled image query_size_lod stderr

7303965

codegen: adapt panic format_args decompiler for new nightly shapes

3341df6

codegen: stop treating core precondition_check as panic entry point

cfb698b

codegen: harden panic format_args fallback for split/pass-through shapes

8423fd4

codegen: preserve raw fn ABI query invariants

8ffe0f5

codegen: harden panic message decoding for nightly call shapes

7fc220e

LegNeato added 6 commits March 6, 2026 18:40

codegen: preserve panic_const messages in panic fast path

c0beae1

codegen: decode panic_bounds_check debug-printf args

b54de5f

compiletests: normalize relative spirv-std paths in stderr

c3c424a

fix lint and spv1.3 stderr for panic/message updates

7e26485

codegen: use size-based alloca for panic arg spill

90926fd

codegen: emit typed local panic spills without typed_alloca

2fe48e0

nazar-pc mentioned this pull request Mar 8, 2026

Unclear ICE #312

Open

fee1-dead requested changes Mar 9, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update toolchain 2026-03-06#545

Update toolchain 2026-03-06#545
LegNeato wants to merge 34 commits intomainfrom
pr-542-latest-nightly-refresh

LegNeato commented Mar 7, 2026

Uh oh!

LegNeato Mar 7, 2026

Uh oh!

nazar-pc commented Mar 7, 2026

Uh oh!

nazar-pc commented Mar 8, 2026

Uh oh!

LegNeato commented Mar 8, 2026

Uh oh!

fee1-dead Mar 9, 2026

Uh oh!

fee1-dead Mar 9, 2026

Uh oh!

fee1-dead Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

LegNeato commented Mar 7, 2026

Requires #542

Uh oh!

LegNeato Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

nazar-pc commented Mar 7, 2026

Uh oh!

nazar-pc commented Mar 8, 2026

Uh oh!

LegNeato commented Mar 8, 2026

Uh oh!

fee1-dead Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

fee1-dead Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

fee1-dead Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants