Keep #[spirv(...)] entry-points from being DCE'd by rustc.#591
Merged
eddyb merged 1 commit intoRust-GPU:mainfrom May 4, 2026
Merged
Keep #[spirv(...)] entry-points from being DCE'd by rustc.#591eddyb merged 1 commit intoRust-GPU:mainfrom
#[spirv(...)] entry-points from being DCE'd by rustc.#591eddyb merged 1 commit intoRust-GPU:mainfrom
Conversation
When building a shader as a `dylib`, rustc's `cross_crate_inlinable` heuristic can mark a `pub fn` entry-point as inlinable, which internalizes it and drops its `OpEntryPoint` before codegen ever runs. Override the query to return `false` for entry-points. Fixes Rust-GPU#590.
eddyb
approved these changes
May 4, 2026
konyogony
referenced
this pull request
in konyogony/physics
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building a shader as a
dylib, rustc'scross_crate_inlinableheuristic can mark apub fnentry-point as inlinable, which internalizes it and drops itsOpEntryPointbefore codegen ever runs.Override the query to return
falsefor entry-points.Fixes #590.