rust: workqueue: fix safety comments in WorkItemPointer for Pin<KBox>#1235
Open
zanni098 wants to merge 1 commit into
Open
rust: workqueue: fix safety comments in WorkItemPointer for Pin<KBox>#1235zanni098 wants to merge 1 commit into
zanni098 wants to merge 1 commit into
Conversation
Darksonn
pushed a commit
to Darksonn/linux
that referenced
this pull request
May 30, 2026
…Rust-for-Linux#1235) Hygon Family 18h CPUs are derived from AMD Family 17h (Zen1) silicon and share the same erratum Rust-for-Linux#1235: hardware may read a stale IsRunning=1 bit during ICR write emulation and silently fail to generate an AVIC_IPI_FAILURE_TARGET_NOT_RUNNING VM-Exit on the sending vCPU. The absence of the VM-Exit causes KVM to miss the required wakeup of blocking target vCPUs, leading to hung vCPUs and unbounded delays in guest execution. Extend the existing AMD Family 17h erratum Rust-for-Linux#1235 workaround to also cover Hygon Family 18h. With IPI virtualization disabled, KVM never sets IsRunning=1 in the Physical ID table, so every non-self IPI generates a VM-Exit and is correctly emulated. Fixes: 8de4a1c ("KVM: SVM: Disable (x2)AVIC IPI virtualization if CPU has erratum Rust-for-Linux#1235") Cc: <stable@vger.kernel.org> Signed-off-by: Tina Zhang <zhang_wei@open-hieco.net> Message-ID: <20260522040014.3380201-1-zhang_wei@open-hieco.net>
Darksonn
pushed a commit
to Darksonn/linux
that referenced
this pull request
May 30, 2026
Pull kvm fixes from Paolo Bonzini:
"arm64:
- Fix ITS EventID sanitisation when restoring an interrupt
translation table.
- Fix PPI memory leak when failing to initialise a vcpu.
- Correctly return an error when the validation of a hypervisor trace
descriptor fails, and limit this validation to protected mode only.
RISC-V:
- Fix invalid HVA warning in steal-time recording
- Return SBI_ERR_FAILURE to guest upon OOM in pmu_event_info() and
pmu_snapshot_set_shmem()
- Fix NULL pointer dereference in SBI v0.1 SEND_IPI handler
- Fix sign extension of value for MMIO loads
s390:
- Fix bugs in vSIE (nested virtualization) and UCONTROL, caused by
the page table rewrite.
x86:
- Apply erratum Rust-for-Linux#1235 workaround (disable AVIC IPI virtualization) on
Hygon Family 18h, just like on AMD Family 17h.
- When KVM_CAP_X86_APIC_BUS_CYCLES_NS is queried on a specific VM,
return the VM's configured APIC bus frequency instead of the
default. This is less confusing (read: not wrong) and makes it
easier to fill in CPUID information that communicates the APIC bus
frequency to the guest.
Selftests:
- Do not include glibc-internal <bits/endian.h>; it worked by chance
and broke building KVM selftests with musl"
* tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm:
KVM: SVM: Disable AVIC IPI virtualization on Hygon Family 18h (erratum Rust-for-Linux#1235)
KVM: selftests: Verify that KVM returns the configured APIC cycle length
KVM: x86: Return the VM's configured APIC bus frequency when queried
KVM: selftests: elf: Include <endian.h> instead of <bits/endian.h>
KVM: s390: Properly reset zero bit in PGSTE
KVM: s390: vsie: Fix redundant rmap entries
KVM: s390: vsie: Fix unshadowing logic
KVM: s390: Fix leaking kvm_s390_mmu_cache in case of errors
KVM: s390: vsie: Fix memory leak when unshadowing
KVM: arm64: Fix nVHE/pKVM hyp tracing error on invalid desc
KVM: arm64: vgic: Free private_irqs when init fails after allocation
KVM: arm64: vgic-its: Reject restored DTE with out-of-range num_eventid_bits
RISC-V: KVM: Fix sign extension for MMIO loads
RISC-V: KVM: Fix NULL pointer dereference in SBI v0.1 SEND_IPI handler
riscv: kvm: return SBI_ERR_FAILURE for pmu_event_info() when OOM
riscv: kvm: return SBI_ERR_FAILURE for pmu_snapshot_set_shmem() when OOM
RISC-V: KVM: Fix invalid HVA warning in steal-time recording
The safety comments in the `WorkItemPointer` implementation for `Pin<KBox<T>>` incorrectly refer to `Arc::into_raw`. This implementation uses `KBox`, not `Arc`; the comments were copied from the `Arc` implementation. The pointer recovered in `run()` originates from `KBox::into_raw` in the corresponding `__enqueue`, so correct the comments to refer to `KBox`. Suggested-by: onur-ozkan <onur-ozkan@users.noreply.github.com> Link: Rust-for-Linux#1233 Signed-off-by: zanni098 <zuhaibkhann098@gmail.com>
zanni098
force-pushed
the
fix-workqueue-safety-comments
branch
from
75ef998 to
4d3b7a6
Compare
Author
|
Cleaned up this PR. It previously had a broken branch: it was based on a divergent point and the diff against the base contained 300+ unrelated files (including foreign What changed:
The PR now shows MERGEABLE with a clean one-file diff. Note for maintainers: per #1233 this still needs to be submitted as a proper patch to the LKML / rust-for-linux mailing list; this GitHub PR is just the reviewable form of the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The safety comments in the impl WorkItemPointer for Pin incorrectly
refer to Arc when they should refer to KBox, since this implementation uses
KBox instead of Arc.
Fix the safety comments to properly reference KBox.
Suggested-by: onur-ozkan onur-ozkan@users.noreply.github.com
Link: #1233
This patch follows the kernel contribution guidelines and is signed off
under the Developer's Certificate of Origin.