internal: error on duplicate #[pin] attribute#120
Open
mentonin wants to merge 2 commits intoRust-for-Linux:mainfrom
Open
internal: error on duplicate #[pin] attribute#120mentonin wants to merge 2 commits intoRust-for-Linux:mainfrom
#[pin] attribute#120mentonin wants to merge 2 commits intoRust-for-Linux:mainfrom
Conversation
adds the error and a compile_fail test to check for it. Closes: Rust-for-Linux#119 Signed-off-by: Luiz Georg <luizgngeorg@gmail.com>
Author
|
I am new to both this project and Rust macros, but this problem seemed easy to tackle. Let me know if I should implement it with a different pattern instead. I am also not sure if this should be documented on the |
nbdd0121
reviewed
Mar 12, 2026
Co-authored-by: Gary Guo <gary@garyguo.net> Signed-off-by: Luiz Georg <luizgngeorg@gmail.com>
nbdd0121
reviewed
Apr 14, 2026
| (len != field.attrs.len(), &*field) | ||
| let diff = len - field.attrs.len(); | ||
| if diff > 1 { | ||
| return Err(dcx.error(field, "#[pin] attribute specified more than once")); |
Member
There was a problem hiding this comment.
Instead of returning an error, could you just report the error and continue? This way it prevents cascading of error caused by not generating any code.
| a: usize, | ||
| } | ||
|
|
||
| fn main() {} |
Member
There was a problem hiding this comment.
If you add a user of Foo here, you should observe the "cascading error" effect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds the error and a compile_fail test to check for it.
Closes: #119