Skip to content

fix(coreaudio): declare aggregate_device_id as mut and check AudioHardwareCreateProcessTap status #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thewh1teagle wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(coreaudio): declare aggregate_device_id as mut and check AudioHardwareCreateProcessTap status #1123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/host/coreaudio/macos/loopback.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,18 +103,20 @@ impl LoopbackDevice {

let mut tap_obj_id: MaybeUninit<AudioObjectID> = MaybeUninit::uninit();
let tap_obj_id = unsafe {
AudioHardwareCreateProcessTap(Some(tap_desc.as_ref()), tap_obj_id.as_mut_ptr());
let status =
AudioHardwareCreateProcessTap(Some(tap_desc.as_ref()), tap_obj_id.as_mut_ptr());
check_os_status(status)?;
tap_obj_id.assume_init()
};
let tap_uid = unsafe { tap_desc.UUID().UUIDString() };

// 2 - Create aggregate device
let aggregate_device_properties = create_audio_aggregate_device_properties(tap_uid);
let aggregate_device_id: AudioObjectID = 0;
let mut aggregate_device_id: AudioObjectID = 0;
let status = unsafe {
AudioHardwareCreateAggregateDevice(
aggregate_device_properties.as_ref(),
NonNull::from(&aggregate_device_id),
NonNull::from(&mut aggregate_device_id),
)
};
check_os_status(status)?;
Expand Down