feat: opus support via libopus and allow registering additional codecs#851
feat: opus support via libopus and allow registering additional codecs#851yara-blue merged 12 commits intoRustAudio:masterfrom
Conversation
d73d0e8 to
eda8f16
Compare
src/decoder/builder.rs
Outdated
| /// | ||
| /// See the documentation for [CodecRegistry] for more info. | ||
| #[cfg(feature = "symphonia")] | ||
| pub fn with_decoder<D>(self) -> Self |
There was a problem hiding this comment.
Since this only works for symphonia decoders this should maybe be named with_symphonia_decoder. On the other hand I see a near future where we drop all the other decoders (I have not seen any issue with the Symphonia decoders and they have been the default for a while). If we do that the name is fine.
There was a problem hiding this comment.
I agree, that makes sense. Updated 👍
|
Looks great to me! There is a trivial conflict, I think your explanation about features deserves to live in the toml, and we might wanna think about the method name for a sec. As soon as that's done LGTM. PS: apologies for the somewhat slow review. Thanks for picking this up and keeping the ball rolling. PPS: it's soo great to see these old issues closed :) |
Signed-off-by: royalmustard <royalmustard@memium.de>
|
Yay 🎉 |
Supersedes #806
Resolves #38
Thanks @royalmustard for starting on this! I took the changes from the previous PR and made a few tweaks:
symphonia-libopusflag. Opus support is a common enough request that I think it makes sense to support this via a flag rather than require users to add the codec manually.