Open
Conversation
kraemv
force-pushed
the
feature/set_of_ref
branch
2 times, most recently
from
b38a2cc to
fc1d408
Compare
dishmaker
reviewed
Feb 27, 2026
kraemv
force-pushed
the
feature/set_of_ref
branch
from
fc1d408 to
7aa875a
Compare
dishmaker
reviewed
Feb 27, 2026
dishmaker
reviewed
Feb 27, 2026
kraemv
force-pushed
the
feature/set_of_ref
branch
from
7aa875a to
43bf173
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello everyone,
in this PR I add a referenced version to the SetOf struct. This can be useful to implement referenced versions of structs containing SetOfs.
In order to allow both decoding from DER bytes and creating references from existing SetOfs, the SetOfRef contains an internal reference that can be both. The inner reference to raw bytes is not pretty, but I do not see another way to implement this with no_std requirements. Most functions like get are then implemented over iterators, that hide the inner reference type. I check sorting on all constructors.
In order for CI to go through, we need a MSRV of 1.87 for the heapless crate.
I am happy to receive feedback on this PR!