Skip to content

chore: migrate from Upbound to Crossplane build infrastructure#101

Merged
schlingemann merged 10 commits intomainfrom
chore/refactor-makefile
Mar 23, 2026
Merged

chore: migrate from Upbound to Crossplane build infrastructure#101
schlingemann merged 10 commits intomainfrom
chore/refactor-makefile

Conversation

@gergely-szabo-sap
Copy link
Copy Markdown
Contributor

@gergely-szabo-sap gergely-szabo-sap commented Aug 11, 2025

This PR migrates the project from using Upbound's build infrastructure to the upstream Crossplane build system.

Changes

  • Build submodule: Updated .gitmodules to use crossplane/build instead of upbound/build
  • Multi-platform builds: Modified GitHub Actions workflows to build linux_amd64 and linux_arm64 images separately using make build PLATFORM=... instead of relying on docker buildx
  • Package publishing: Switched from make publish to make xpkg.build and make xpkg.release.publish for crossplane package distribution
  • Image building: Migrated from image.mk to imagelight.mk for simpler image builds
  • Dockerfile consolidation:
    • Removed separate Dockerfiles for controller and configuration packages
    • Added new provider-cloudfoundry Dockerfile using distroless base image
  • Project naming: Updated PROJECT_NAME and PROJECT_REPO to use crossplane-provider-{name} naming convention
  • E2E tests: Simplified test configuration by removing separate controller image handling
  • Documentation: Added local kind build and e2e test instructions to DEVELOPER.md

Motivation

Align with Crossplane's upstream build tools and eliminate dependency on Upbound-specific infrastructure.

@maximilianbraun
Copy link
Copy Markdown
Member

👋 if we can make ARM possible in parallel, that would be awesome. Not sure how feasible that is.

Copy link
Copy Markdown
Member

@sdischer-sap sdischer-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Put some comments.

Comment thread DEVELOPER.md Outdated
Comment thread Makefile
Comment thread test/e2e/main_test.go
@gergely-szabo-sap
Copy link
Copy Markdown
Contributor Author

👋 if we can make ARM possible in parallel, that would be awesome. Not sure how feasible that is.

Very good suggestion. Let's see first, whether the sequential approach works. Then I'd go for the parallel building.

@sdischer-sap
Copy link
Copy Markdown
Member

Looks like something is failing in the builds. Let me know when I should do another review.

@gergely-szabo-sap gergely-szabo-sap changed the title chore: Refactoring makefile chore: migrate from Upbound to Crossplane build infrastructure Mar 16, 2026
@gergely-szabo-sap gergely-szabo-sap force-pushed the chore/refactor-makefile branch from 5052615 to 117e3da Compare March 16, 2026 11:57
@gergely-szabo-sap gergely-szabo-sap force-pushed the chore/refactor-makefile branch from 117e3da to 9885c90 Compare March 16, 2026 12:00
@gergely-szabo-sap gergely-szabo-sap force-pushed the chore/refactor-makefile branch from 9885c90 to 35d3daa Compare March 16, 2026 13:44
@gergely-szabo-sap gergely-szabo-sap force-pushed the chore/refactor-makefile branch from 35d3daa to 41d7933 Compare March 17, 2026 09:32
@gergely-szabo-sap gergely-szabo-sap marked this pull request as ready for review March 17, 2026 09:50
@SatabdiG SatabdiG requested a review from schlingemann March 17, 2026 12:46
@gergely-szabo-sap gergely-szabo-sap marked this pull request as draft March 18, 2026 14:51
@gergely-szabo-sap gergely-szabo-sap marked this pull request as ready for review March 19, 2026 07:56
Copy link
Copy Markdown
Member

@schlingemann schlingemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's give it a try and create a RC

@gergely-szabo-sap gergely-szabo-sap force-pushed the chore/refactor-makefile branch from ec1125c to 311a94f Compare March 23, 2026 15:34
@schlingemann schlingemann merged commit e784bee into main Mar 23, 2026
12 checks passed
@schlingemann schlingemann deleted the chore/refactor-makefile branch March 23, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REFACTOR] Refactor and document Makefile

4 participants