Skip to content

fix: separate org and space role caches#225

Merged
gergely-szabo-sap merged 1 commit intomainfrom
bug/clifford-panic-orgrole
Mar 30, 2026
Merged

fix: separate org and space role caches#225
gergely-szabo-sap merged 1 commit intomainfrom
bug/clifford-panic-orgrole

Conversation

@gergely-szabo-sap
Copy link
Copy Markdown
Contributor

Split single roleCache/userCache into orgRoleCache/orgUserCache and spaceRoleCache/spaceUserCache to prevent data contamination between GetOrgRoles and GetSpaceRoles functions.

Also fixed cache check in GetOrgRoles to use AND logic instead of OR.

Copy link
Copy Markdown
Collaborator

@SatabdiG SatabdiG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Copy Markdown
Contributor

@Kukkerem Kukkerem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Split single roleCache/userCache into orgRoleCache/orgUserCache and
spaceRoleCache/spaceUserCache to prevent data contamination between
GetOrgRoles and GetSpaceRoles functions.

Also fixed cache check in GetOrgRoles to use AND logic instead of OR.
@gergely-szabo-sap gergely-szabo-sap force-pushed the bug/clifford-panic-orgrole branch from e3ce9a0 to cd8b183 Compare March 27, 2026 09:27
@gergely-szabo-sap gergely-szabo-sap merged commit 9df3fe5 into main Mar 30, 2026
12 checks passed
@gergely-szabo-sap gergely-szabo-sap deleted the bug/clifford-panic-orgrole branch March 30, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] export CLI crashes when interactively exporting orgroles + spaceroles

3 participants