Fix splitArgs silently dropping quoted arguments#542
Open
jakemismas wants to merge 1 commit intoSKCraft:masterfrom
Open
Fix splitArgs silently dropping quoted arguments#542jakemismas wants to merge 1 commit intoSKCraft:masterfrom
jakemismas wants to merge 1 commit intoSKCraft:masterfrom
Conversation
The argsPattern regex has two capture groups: group(1) for unquoted args and group(2) for quoted args. Only group(1) was being read, so any quoted argument like "-Dfoo=bar baz" was added as null to the argument list, corrupting the JVM command line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
splitArgsregex inJavaProcessBuilderhas two capture groups: group(1) for unquoted args and group(2) for quoted args. Only group(1) was ever read, so any quoted argument like"-Dfoo=bar baz"was added asnullto the flags list, corrupting the JVM command line.Changes
launcher/src/main/java/com/skcraft/launcher/launch/JavaProcessBuilder.java: fall back to group(2) when group(1) is null