Feat/lower prices#40
Closed
TheBjoRedCraft wants to merge 2 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR lowers several in-game trader prices while also migrating the plugin to the newer dev.slne.surf.api.* (Paper) package layout and updating build/CI infrastructure to match the new dependency setup.
Changes:
- Reduced prices for selected
Tradesentries (e.g., invisible item frame, light block, trader clock). - Migrated Surf API imports/usages from
dev.slne.surf.surfapi.*todev.slne.surf.api.*across plugin code (including PAPI hooks). - Updated build and release pipeline: Gradle wrapper/versioning, plugin/dependency coordinates, and publish workflow reuse.
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/dev/slne/spawn/trader/util/trader-util.kt | Updates Surf component builder import to the new Surf API package. |
| src/main/java/dev/slne/spawn/trader/util/PermissionRegistry.kt | Switches PermissionRegistry import to new Paper API package. |
| src/main/java/dev/slne/spawn/trader/trades/Trades.kt | Migrates Surf imports and lowers several trade prices. |
| src/main/java/dev/slne/spawn/trader/service/TraderVisibilityService.kt | Migrates Surf core util/font/text imports; trims appear/leave message lists. |
| src/main/java/dev/slne/spawn/trader/service/TraderTradeService.kt | Migrates Surf sendText import. |
| src/main/java/dev/slne/spawn/trader/papi/placeholder/SpawnTraderVisiblePlaceholder.kt | Migrates PAPI placeholder base class import to new Paper API package. |
| src/main/java/dev/slne/spawn/trader/papi/PapiExpansion.kt | Migrates PAPI expansion import to new Paper API package. |
| src/main/java/dev/slne/spawn/trader/PaperMain.kt | Migrates builder/event/viewFrame imports and switches to the new PAPI hook registration API. |
| src/main/java/dev/slne/spawn/trader/listener/TraderClockInteractListener.kt | Migrates Surf sendText import. |
| src/main/java/dev/slne/spawn/trader/listener/NpcInteractListener.kt | Migrates viewFrame import to new Paper API package. |
| src/main/java/dev/slne/spawn/trader/gui/view-util.kt | Migrates Surf GUI helper imports to new core/paper API packages. |
| src/main/java/dev/slne/spawn/trader/gui/SpawnTraderView.kt | Migrates Surf GUI imports (lore/displayName/titleBuilder/toSmallCaps). |
| src/main/java/dev/slne/spawn/trader/gui/MenuHeads.kt | Migrates buildItem import to new Paper API package. |
| src/main/java/dev/slne/spawn/trader/command/SpawnTraderCommand.kt | Migrates Surf sendText import. |
| settings.gradle.kts | Updates plugin management repository URL. |
| gradle/wrapper/gradle-wrapper.properties | Updates Gradle distribution URL. |
| gradle.properties | Updates project version string. |
| build.gradle.kts | Switches to new Surf Gradle plugin coordinates and changes dependency versioning strategy. |
| .github/workflows/publish.yml | Replaces local workflow steps with a reusable workflow invocation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3
to
5
| import dev.slne.surf.api.paper.permission.PermissionRegistry | ||
|
|
||
| object PermissionRegistry : PermissionRegistry() { |
| files: ${{ env.JAR_FILES }} | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| uses: SLNE-Development/surf-workflows/.github/workflows/build-publish-release-gradle.yml@master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.