feat(account): configurable activation URL + AUTH_ACTIVATION_ENABLED …#10
Merged
Conversation
…env toggle Closes #9. The activation email link was hardcoded to `${baseUrl}/${path}/activate/<token>` (backend, path-style), so it couldn't be pointed at an SPA frontend that expects a query-style token on a dedicated route (e.g. /activate?token=<token>). - Add `auth.activationUrl` (mirrors auth.resetPasswordUrl) with a `{token}` placeholder and `AUTH_ACTIVATION_URL` override. Default reproduces the historical URL exactly, so existing consumers are unaffected. AccountNotifications now renders ActivationUrl.replace("{token}", token). - Allow toggling activation via env: `auth.activation.enabled = ${?AUTH_ACTIVATION_ENABLED}` (AccountSettings.ActivationEnabled already reads auth.activation.enabled). Both changes are additive and default to current behavior. Version 0.8.4 -> 0.8.5. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
=======================================
Coverage 74.71% 74.72%
=======================================
Files 55 55
Lines 2567 2568 +1
Branches 361 407 +46
=======================================
+ Hits 1918 1919 +1
Misses 649 649
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…env toggle
Closes #9.
The activation email link was hardcoded to
${baseUrl}/${path}/activate/<token>(backend, path-style), so it couldn't be pointed at an SPA frontend that expects a query-style token on a dedicated route (e.g. /activate?token=).auth.activationUrl(mirrors auth.resetPasswordUrl) with a{token}placeholder andAUTH_ACTIVATION_URLoverride. Default reproduces the historical URL exactly, so existing consumers are unaffected. AccountNotifications now renders ActivationUrl.replace("{token}", token).auth.activation.enabled = ${?AUTH_ACTIVATION_ENABLED}(AccountSettings.ActivationEnabled already reads auth.activation.enabled).Both changes are additive and default to current behavior. Version 0.8.4 -> 0.8.5.