Skip to content

fix(account): repair OAuth social login end-to-end (#11)#12

Merged
fupelaqu merged 2 commits into
mainfrom
fix/oauth
Jun 9, 2026
Merged

fix(account): repair OAuth social login end-to-end (#11)#12
fupelaqu merged 2 commits into
mainfrom
fix/oauth

Conversation

@fupelaqu

@fupelaqu fupelaqu commented Jun 9, 2026

Copy link
Copy Markdown
Contributor
  • OAuth2Service.userInfo: drop null JSON values before toString to stop NPE on providers returning nullable profile fields (e.g. GitHub /user)
  • GitHubApiService: fall back to GET /user/emails for the primary verified email when /user returns a private (null) email, so login resolves
  • add post-auth redirect: callback now 302s to a configurable frontend URL (auth.oauth.callback.redirect-url / AUTH_OAUTH_CALLBACK_REDIRECT_URL) with status=success|error[&reason], session cookie set on the same response; mirrored in both tapir (OAuthServiceEndpoints) and akka-http (OAuthService)
  • bump version to 0.8.6

fupelaqu and others added 2 commits June 9, 2026 09:01
- OAuth2Service.userInfo: drop null JSON values before toString to stop
  NPE on providers returning nullable profile fields (e.g. GitHub /user)
- GitHubApiService: fall back to GET /user/emails for the primary verified
  email when /user returns a private (null) email, so login resolves
- add post-auth redirect: callback now 302s to a configurable frontend URL
  (auth.oauth.callback.redirect-url / AUTH_OAUTH_CALLBACK_REDIRECT_URL) with
  status=success|error[&reason], session cookie set on the same response;
  mirrored in both tapir (OAuthServiceEndpoints) and akka-http (OAuthService)
- bump version to 0.8.6

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 35.89744% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.49%. Comparing base (b7d9e6e) to head (8dc975f).

Files with missing lines Patch % Lines
...app/softnetwork/account/spi/GitHubApiService.scala 0.00% 15 Missing ⚠️
...etwork/account/service/OAuthServiceEndpoints.scala 23.07% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   74.72%   74.49%   -0.23%     
==========================================
  Files          55       55              
  Lines        2568     2596      +28     
  Branches      407      403       -4     
==========================================
+ Hits         1919     1934      +15     
- Misses        649      662      +13     
Flag Coverage Δ
unittests 74.49% <35.89%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fupelaqu fupelaqu merged commit b5ed42c into main Jun 9, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant