Skip to content

Interfaces should not have a base type#494

Merged
SamboyCoding merged 3 commits intoSamboyCoding:developmentfrom
AssetRipper:no-interface-base-method
Dec 24, 2025
Merged

Interfaces should not have a base type#494
SamboyCoding merged 3 commits intoSamboyCoding:developmentfrom
AssetRipper:no-interface-base-method

Conversation

@ds5678
Copy link
Copy Markdown
Contributor

@ds5678 ds5678 commented Oct 21, 2025

Note: the unit tests do not actually test the reason for this pull request. They were written while I was attempting to reproduce the issue, but none of the methods in the test games appear to exhibit the problem.

Resolves #492

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 21, 2025

Pull Request Test Coverage Report for Build 18693904330

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 34.36%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Cpp2IL.Core/Model/Contexts/MethodAnalysisContext.cs 1 2 50.0%
Totals Coverage Status
Change from base Build 18333364266: 0.05%
Covered Lines: 4196
Relevant Lines: 10849

💛 - Coveralls

@ds5678 ds5678 changed the title Interface methods should not have a base method Interfaces should not have a base type Oct 21, 2025
@SamboyCoding SamboyCoding merged commit 6d2c5a1 into SamboyCoding:development Dec 24, 2025
9 checks passed
@ds5678 ds5678 deleted the no-interface-base-method branch January 18, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interface methods can have BaseMethod but shouldn't

3 participants