Allow pure python Fq for beta approximation.#570
Conversation
|
Looks like it needs some unit tests. |
|
Not a priority for 6.0 but will be good to have |
lucas-wilkins
left a comment
There was a problem hiding this comment.
This looks OK and it looks like it will do what it is supposed to do, but there does seem to be a lot of mordernisation to be done on these files. If assessed it more consistency with existing code, rather than something approximating best practice.
| #: functions by reference), then set this to false. | ||
| opencl = None # type: bool | ||
| #: True if the model is compiled with C or OpenCL | ||
| compiled = None # type: bool |
There was a problem hiding this comment.
It might make sense to make this a dataclass and avoid having variables initialised to values outside their type
|
I think @butlerpd said he would try writing some python models to check with. |
|
yes @lucas-wilkins that bit is now on me. |
krzywon
left a comment
There was a problem hiding this comment.
A couple of suggestions, but overall, this will be good for model writers.
Allow pure python F(q) functions such as the following:
Test using: