fix metric calculation caused by mismatched pair comparisons#60
Open
kleinercubs wants to merge 1 commit intoScalingIntelligence:mainfrom
Open
fix metric calculation caused by mismatched pair comparisons#60kleinercubs wants to merge 1 commit intoScalingIntelligence:mainfrom
kleinercubs wants to merge 1 commit intoScalingIntelligence:mainfrom
Conversation
Collaborator
|
Thanks for catching that @kleinercubs. @pythonomar22 let's look into this as we are revamping metrics calculations and summary statistics. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The evaluation results must be saved in the order of their keys (
problem_id). Otherwise, when some eval results are missing, the speedup computed withgeometric_mean_speed_ratio_correct_onlywould use mismatched pairs and produce incorrect results.