add samesite support#84
Open
mum-never-proud wants to merge 4 commits into
Open
Conversation
mum-never-proud
force-pushed
the
add-samesite-support
branch
from
53a936c to
d336ad9
Compare
mum-never-proud
force-pushed
the
add-samesite-support
branch
from
d336ad9 to
00cfd1c
Compare
|
@ScottHamper do you have any ETA on when this might get merged? :) |
Owner
|
Probably never, to be honest, though it is a well done PR! See #86 |
|
@ScottHamper Haha ok fair enough :) The only reason I asked is because this package (https://github.com/abersager/redux-persist-cookie-storage) uses yours as a dependency. Your points in #86 are valid though. We'll either write our own adapter or switch to something else with local storage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #85