Add types before brackets, not depend on codeigniter type db object, update class Name#2
Open
hasnat wants to merge 2 commits intoSeanJA:masterfrom
Open
Add types before brackets, not depend on codeigniter type db object, update class Name#2hasnat wants to merge 2 commits intoSeanJA:masterfrom
hasnat wants to merge 2 commits intoSeanJA:masterfrom
Conversation
Author
|
updated tests, added interface to not depend on codeigniter db object, changed class name to |
Owner
|
I changed some stuff and broke your pull request, will look at it when I get home and add the fixes in |
Author
|
I briefly checked the changes, I see those changes will make this stop working for php 5.2 |
Author
|
also thanks for great work and looking into this pull request. |
Owner
|
Sure, it is just the namespacing stuff that makes it not work with php 5.2 right? |
Author
|
yeah, namespaces and composer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding more begin_or/begin_and wont add AND/OR before brackets, hence breaks the query.
these changes now by default it would add AND/OR.
you can specify false to not add forcefully.