Feature: Better Straight Wire Routing#501
Draft
jandrec27 wants to merge 9 commits intoSebLague:mainfrom
Draft
Conversation
Author
|
Cleaned up some strays that made it into the commit |
Simplified the implementation so that most of the logic is being done in WireInstance and GridHelper. Completely removed changes to ChipInteraction Controller Fixed some bugs with the initial implementation too The router now turns on and off with the forceStraightWires flag Also, the router is completely inactive when editing wires, which I believe is more practical Finally, the router works from the first pin it's placed, originally, it would only work once a point on the wire has been placed down
Fixed an alignment issue where, when a wire is finished placing, it get's snapped to the target pin, this would result in a slight misalignment of the second to last point on the wire. The fix now reroutes that point when finishing placement of a wire. Removed 90 degree routing mode for now, until I am able to implement it later. Want to look at curved wires first.
Fixed a bug with routing when last point was connected to a pin Releasing shift key returns wire to straight line mode
Re-implemented the curved wire bends from earlier versions Just used Sebastian's existing function to do so. Straight or Curved wires can be selected in the preferences menu
Author
|
Re-added the curved wires from older versions |
Most of this commit revolves around setting up some things to change the direction in which wires attempt to terminate The idea is to make it possible to change between wires ending on a vertical or horizontal line when being routed
Contributor
|
Hey this looks absolutely awesome! Will you continue to work on it? or is it complete but still marked as a draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still a work in progress, but the idea is better wiring routing when drawing straight wires, similar to what's found in programs like Kicad.
I intend to implement a 90° and 45° corner mode, but right now, only 45° mode is implemented.
I did notice that some code for rounded corners still exists, which would probably work better with 90° corners.
AutoRouter.Demo.mp4