fix(inference): per-precision line labels when multiple precisions selected#426
Merged
Merged
Conversation
…lected When more than one precision is shown, each precision is its own curve, but line labels were deduplicated by hardware key — so only one of the two curves for a given hardware got a label, and that label omitted the precision. Now, when >1 precision is selected, every curve gets its own line label and the text includes the precision (e.g. "B200 (vLLM) FP8" vs "B200 (vLLM) FP4"). With a single precision selected, behavior is unchanged (one label per hardware, no precision suffix). Applies to both the interactivity (greedy placement) and TTFT/E2EL (endpoint) chart types, in the static render and the zoom re-placement paths. Overlay (unofficial run) line labels also gain the precision suffix so the two precision curves of an overlay stay distinguishable. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When more than one precision is selected (e.g. FP4 and FP8), each precision is rendered as its own curve, but the line labels were deduplicated by hardware key. The result:
See the reported screenshot: with FP4 + FP8 shown, "B200 (vLLM)" labeled only one of the two B200 lines and gave no precision.
Fix
When
selectedPrecisions.length > 1:hw_precisioninstead of justhw).B200 (vLLM) FP8andB200 (vLLM) FP4.With a single precision selected, behavior is unchanged — one label per hardware, no precision suffix.
Applied consistently across:
Overlay (unofficial run) support
Per
AGENTS.md, the change covers the?unofficialrun=overlay path too: overlay line labels gain the precision suffix when multiple precisions are shown, so the two precision curves of an overlay stay distinguishable. Overlay labels were already keyed per series, so the only gap was the missing precision text, now fixed in both static and zoom paths.Tests
Added a case to
cypress/e2e/line-labels.cy.tsthat loads/inference?i_linelabel=1&i_prec=fp4,fp8and asserts that at least one line label containsFP8and one containsFP4.🤖 Generated with Claude Code
Note
Low Risk
Chart labeling-only change in ScatterGraph with single-precision behavior preserved; no auth or data pipeline impact.
Overview
When more than one precision is selected on inference scatter charts, line labels now follow one label per curve (dedup by series key instead of hardware only) and append the precision (e.g.
B200 (vLLM) FP8vsFP4) vialineLabelTextandgetPrecisionLabel.Behavior is unchanged with a single precision selected. The same rules apply to interactivity greedy placement, TTFT / E2E endpoint labels, unofficial-run overlay labels, and the matching zoom re-placement paths.
A Cypress case loads
i_linelabel=1&i_prec=fp4,fp8and asserts at least one label contains FP8 and one FP4.Reviewed by Cursor Bugbot for commit 22764d5. Bugbot is set up for automated code reviews on this repo. Configure here.